Code Monkey home page Code Monkey logo

Comments (8)

keilw avatar keilw commented on September 24, 2024 2

A) Rename ParserException to MeasurementParseException for consistency with a large number of APIs and frameworks (JSR 310, 354, Jackson, Gradle,...) marking the old one deprecated.

from unit-api.

keilw avatar keilw commented on September 24, 2024

Removed usage of ParserException from a format() method, so I would leave it for now, and close this one. Leaving #58 open.

from unit-api.

keilw avatar keilw commented on September 24, 2024

Reopened this as it would be cleaner and more consistent with JSR 310, 354 and others.

The idea would be to leave ParserException in the API 2.0 if we have to (for backward compatibility) but simply extend a new MeasurementParseException and mark ParserException deprecated.

Please vote on either:

from unit-api.

keilw avatar keilw commented on September 24, 2024

B) Keep ParserException as it is.

from unit-api.

dautelle avatar dautelle commented on September 24, 2024

Why not MeasureParseException (makes more sense and shorter) ?

from unit-api.

desruisseaux avatar desruisseaux commented on September 24, 2024

But this exception can also occur while parsing Unit objects instead of Measure objects, isn't it?

from unit-api.

keilw avatar keilw commented on September 24, 2024

Yes, but Measure is not an API element any more, Quantity is. Having the base exception start with Measurement, I thought MeasurementParseException (similar to DateTimeParseException in Date/Time) would be a good name. We have a QuantityFormat interface now, so both Unit and Quantity can be parsed, which is why UnitParseException won't be enough.

from unit-api.

keilw avatar keilw commented on September 24, 2024

Although it is only an SPI element of Indriya, we have a Measurement interface ever since JSR 363, so calling it MeasurementParseException sounds more consequent since this exception will also extend MeasurementException. Compared to IncommensurableException it is just one more character ;-)

from unit-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.