Comments (8)
A) Rename ParserException
to MeasurementParseException
for consistency with a large number of APIs and frameworks (JSR 310, 354, Jackson, Gradle,...) marking the old one deprecated.
from unit-api.
Removed usage of ParserException from a format() method, so I would leave it for now, and close this one. Leaving #58 open.
from unit-api.
Reopened this as it would be cleaner and more consistent with JSR 310, 354 and others.
The idea would be to leave ParserException
in the API 2.0 if we have to (for backward compatibility) but simply extend a new MeasurementParseException
and mark ParserException
deprecated.
Please vote on either:
from unit-api.
B) Keep ParserException
as it is.
from unit-api.
Why not MeasureParseException (makes more sense and shorter) ?
from unit-api.
But this exception can also occur while parsing Unit
objects instead of Measure
objects, isn't it?
from unit-api.
Yes, but Measure
is not an API element any more, Quantity
is. Having the base exception start with Measurement, I thought MeasurementParseException
(similar to DateTimeParseException
in Date/Time) would be a good name. We have a QuantityFormat interface now, so both Unit
and Quantity
can be parsed, which is why UnitParseException
won't be enough.
from unit-api.
Although it is only an SPI element of Indriya, we have a Measurement
interface ever since JSR 363, so calling it MeasurementParseException
sounds more consequent since this exception will also extend MeasurementException
. Compared to IncommensurableException
it is just one more character ;-)
from unit-api.
Related Issues (20)
- Improve code coverage of ServiceProvider HOT 3
- Fix problem with maven-javadoc-plugin
- MR 1 Spec Review
- Could Quantity use a symbol, too? HOT 1
- Upgrade JDK to Java 11 or higher
- Replace Bintray/JCenter in API build settings
- Enable discovery of prefix classes via SPI HOT 1
- Improve the JavaDoc of UnitFormat
- Remove unnecessary OSGI imports
- Convert Quantity to most fitting Prefix HOT 7
- improve interoperability of Quantity with Hibernate JPA HOT 7
- Should not cache the ServiceProvider implementation HOT 8
- Incorporate the new SI Prefixes
- Upgrade CI JDK to Java 17 or higher
- Update module-info
- Replace tabulations by 4 spaces HOT 2
- Should we deprecate MetricPrefix.DEKA()? HOT 4
- Update Spec Document for MR2 HOT 5
- enum missing in javax.measure.MetricPrefix HOT 2
- Units can have non-integer Dimension HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unit-api.