Code Monkey home page Code Monkey logo

Comments (2)

desruisseaux avatar desruisseaux commented on September 24, 2024

What was the decision for that one?

from unit-api.

keilw avatar keilw commented on September 24, 2024

We specified that the actual SystemOfUnits is null if a wrong or non-existent name was passed to http://unitsofmeasurement.github.io/unit-api/site/apidocs/javax/measure/spi/SystemOfUnitsService.html. #65 addresses the need to use a constant in the RI like GRAM, so you can do SystemOfUnits.getUnit("g") instead. This method uses a Lambda to filter the result, the method in question retrieves values from a Map, so if you pass a non-existent or non-defined quantity class, it returns null. As we even return null for the entire unit system since 1.0 it does not make sense to do something different for one method as for the others.

It always returned null based on the call to Map, now the JavaDoc explains the behavior like it does in the other two cases (including SystemOfUnitsService).
It has been clarified, I don't think we should try to change the behavior, else we had to either deal with Optional or introduce new exceptions.
Like NoSuchUnitException, UnitExistsException or UnitSystemException in UCAR Units. Also see the discussion and input about throwing exceptions in #65.

from unit-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.