Use exception catching, possibly unnecessary performance overhead about indriya HOT 7 CLOSED

from indriya.

@fengyizhu What does this graph show, and is there a test suite you can share to replicate?

@andi-huber What was the BigInteger extraction done there? I understand isIntegerOnly() check simply does a Java type check, but why not apply isInteger() or try reuse the if(decimal.scale()<=0) part instead of trying the exception first?

from indriya.

#388

from indriya.

@keilw Please See #388

from indriya.

Indeed, producing stacktraces just to do a check is costly. I merged #388

see also https://stackoverflow.com/questions/1078953/check-if-bigdecimal-is-an-integer-in-java

from indriya.

@andi-huber @keilw Is there a plan and time to release a revised version?

from indriya.

The scope is here: https://github.com/unitsofmeasurement/indriya/milestone/10 but there's not a concrete time.

from indriya.