Code Monkey home page Code Monkey logo

Comments (5)

dwillis avatar dwillis commented on July 28, 2024

+1

from congress.

konklone avatar konklone commented on July 28, 2024

Done. From the comments above the new activation_from method:

find the first action beyond the standard actions every bill gets.
- if the bill's first action is "referral", then the first non-referral action
    most common
    e.g. hr3590-111 (active), s1-113 (inactive)
- if the bill's first action is "action", then the next action, if one is present
    resolutions
    e.g. sres5-113 (active), sres4-113 (inactive)
- if the bill's first action is anything else (e.g. "vote"), then that first action
    bills that skip committee
    e.g. s227-113 (active)

This catches normal bills, House and Senate resolutions that I've found, and cases where leadership introduces a bill and skips committee (in the Senate anyway).

from congress.

konklone avatar konklone commented on July 28, 2024

Also, there are extensive tests now in test/test_bill_history.py. If you make any changes or additions to how the history flags work, please do add tests to that file, following the examples of other tests there.

Same for test/test_bill_actions.py - if you affect how actions get semantically parsed, do add/update the tests in that file.

from congress.

konklone avatar konklone commented on July 28, 2024

It's not good enough yet. :(

from congress.

konklone avatar konklone commented on July 28, 2024

OK, it is now. I caught a bug in marking some actions as referrals, and made it so it specifically ignored sponsors' introductory remarks. Now, in the 113th Congress, it marks only ~80 of the ~1600 bills/resolutions as "active", which feels right.

from congress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.