Code Monkey home page Code Monkey logo

Comments (10)

plorenzatto avatar plorenzatto commented on August 21, 2024 2

Yes, I think we can remove them. Although it would be nice to replace AutoARIMA with ARIMA.

I'll remove AutoARIMA from deps and log a warning that it's not available while keeping ARIMA. Would that it be ok for you?

edit: clarification

from darts.

pennfranc avatar pennfranc commented on August 21, 2024 1

@plorenzatto Thanks a lot for contributing, I think your proposed changes could be very useful! I think making torch and fbprophet optional like you suggested makes sense. But I'm a bit unsure when it comes to statsmodels, since in addition to being used in 3 models, it is also used in some functions from our statistics module.

I believe these parts should work without any compromises in the core version:

  • TimeSeries class
  • backtesting module (without TorchForecastingModel support)
  • at least some models from the models module
  • preprocessing module
  • utils module (except the torch part)
  • metrics module

Pretty much everything except some of the more fancy forecasting models for now I believe. What are your thoughts?

from darts.

TheMP avatar TheMP commented on August 21, 2024

Hi @plorenzatto,

thank you for bringing this up - this is a very good point that's been also in our backlog for a while already.

Is it something you would like to maybe contribute yourself/are you okay with waiting until we deliver this on our side?

from darts.

plorenzatto avatar plorenzatto commented on August 21, 2024

I'm planning to work on this and send a PR when it's ready.

I have some questions about this:

  • Which functionalities/modules must absolutely work with the default installation?
  • How did you originally thought of solving this issue?

from darts.

plorenzatto avatar plorenzatto commented on August 21, 2024

@TheMP I'm working on #177 on this. Could you give me some input on the points that I mentioned in the previous message?

from darts.

plorenzatto avatar plorenzatto commented on August 21, 2024

I agree with the general idea @pennfranc.

Indeed statsmodels is a dependency of metrics via statistics so better to keep it in the main requirements.

I have some doubts:

  • darts/tests/test_dataset.py depends on ..models.torch_forecasting_model._TimeSeriesSequentialDataset not sure if it's meant to be torch specific or not.
  • backtesting.explore_models uses AutoARIMA and Prophet by default. Can we remove them?

from darts.

pennfranc avatar pennfranc commented on August 21, 2024

Good points.

  • This is definitely specific to our TorchForecastingModel since it tests a subclass of ours of a torch class (torch.utils.data.Dataset). The naming of this test case could probably be made to better reflect this fact.
  • Yes, I think we can remove them. Although it would be nice to replace AutoARIMA with ARIMA.

from darts.

dboyleitrs avatar dboyleitrs commented on August 21, 2024

Hi - Just wondering if there is an estimate when this change might be in place. Sorry I'm not helping with the work but would like to use the u8darts library in production but previously mentioned dependencies create too large of a Docker image.

from darts.

hrzn avatar hrzn commented on August 21, 2024

@dboyleitrs We are evaluating our options to solve this issue. Hopefully we should be able to release this within a couple of weeks or so.

from darts.

hrzn avatar hrzn commented on August 21, 2024

This is implemented in develop, and will be part of the next release:

  • pip install u8darts installs core only
  • pip install u8darts[all] installs everything
  • pip install u8darts[torch] installs core + torch models
  • pip install u8darts[fbprophet] installs core + Prophet
  • pip install u8darts[pmdarima] installs core + AutoARIMA

from darts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.