Comments (3)
A couple things:
- Can you issue this PR against
base_v2
instead of the currentbase
? - It might be that this is against the wrong base namespace since
Optional.flatMap
exists inbase_v2
.- Possibly related: looks like
isSome.doc
andisNone.doc
are using the old deprecated doc type
- Possibly related: looks like
- Since this PR isn't updating any existing definitions, it should have an empty patch - you can just
delete.patch Optional.patch
in your PR namespace. Local churn like this when you're adding new definitions can just be deleted when you're prepping the PR.
from base.
Ok! @pchiusano thanks for the help and pointers! Trying this one again! This time against the actual right version of .base
The changes summarized below are available for you to review, using the following command:
pull-request.load https://github.com/unisonweb/base:.trunk.Optional https://github.com/rlmark/my-unison-repo2:.myBase.Optional
Added definitions:
contains : a -> Optional a -> Boolean (+2 metadata)
contains.doc : Doc (+2 metadata)
exists : (a ->{g} Boolean) -> Optional a ->{g} Boolean (+2 metadata)
exists.doc : Doc (+2 metadata)
filter : (a ->{g} Boolean) -> Optional a ->{g} Optional a (+2 metadata)
filter.doc : Doc (+2 metadata)
fold : '{g} b -> (a ->{g} b) -> Optional a ->{g} b (+2 metadata)
fold.doc : Doc (+2 metadata)
forAll : (a ->{g} Boolean) -> Optional a ->{g} Boolean (+2 metadata)
forAll.doc : Doc (+2 metadata)
getOrElse : a -> Optional a -> a (+2 metadata)
getOrElse.doc : Doc (+2 metadata)
mapOptional : (a ->{g} Optional b) -> [a] ->{g} [b] (+2 metadata)
mapOptional.doc : Doc (+2 metadata)
toList.doc : Doc (+2 metadata)
unzip : Optional (a, b) -> (Optional a, Optional b) (+2 metadata)
unzip.doc : Doc (+2 metadata)
zip : Optional a -> Optional b -> Optional (a, b) (+2 metadata)
zip.doc : Doc (+2 metadata)
from base.
Great, this is all set. Made a few minor fixups to the docs - there was a stray closing }
and I turned an inline signature to just a link to {Universal.===}
.
from base.
Related Issues (20)
- ByteArray.new! should be effect-polymorphic HOT 1
- PR to add Function.tap and Debug.tap HOT 1
- Add Text.contains: Text -> Text -> Boolean HOT 1
- Array indexing, snoc, and cons functions HOT 3
- Array.{foldLeft, foldRight, empty, singleton} HOT 3
- Add builtins for launching external processes HOT 1
- Add functions for reading an entire file and closing it HOT 1
- absurd.doc: relax claims HOT 1
- Add Bytes.splitAt HOT 1
- Add Md5 : HashAlgorithm HOT 1
- Use Debug.toText instead of Debug.trace in test.randomWithSeed HOT 1
- Rename test.random HOT 2
- Add data.Set.isEmpty and doc HOT 1
- hmac and hmacBytes docs seem a bit off HOT 1
- Class.alphanumeric.doc uses Class.letter for example HOT 1
- Add effectful versions of List.fill and Ask.provide HOT 1
- Text rendering for Pretty?
- Add Ask.toStore HOT 1
- Add some Random generators HOT 1
- Unreliable set of sets HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from base.