Code Monkey home page Code Monkey logo

Comments (2)

ntrncic avatar ntrncic commented on August 16, 2024

@pitsevich please add doc strings to any new classes methods. It's hard to understand what the code is trying to do.

from etools.

gpg90 avatar gpg90 commented on August 16, 2024

@domdinicola @ntrncic I think I agree and it's best to have that removed.

but a few words on why this was added.

we had 2 issues reported on Auditor Portal module - one & two.

Basically, both of them are QA findings about random hashes sometimes being added to the end of filenames (that's what the detault storage back-end does in case when a file is uploaded with existing name).

In order to fix this, we've added this mixin which creates a sub-folder with hash name, which keeps the original file names.
However, it is probably an overkill for this case - which makes things more complicated than they should be.


I think we'll remove this code, and will mark this ticket as wont-fix:
https://trello.com/c/3o1mUZ4t/122-random-text-appearing-at-the-end-of-an-attachment

@ntrncic sounds good?

from etools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.