Comments (2)
@pitsevich please add doc strings to any new classes methods. It's hard to understand what the code is trying to do.
from etools.
@domdinicola @ntrncic I think I agree and it's best to have that removed.
but a few words on why this was added.
we had 2 issues reported on Auditor Portal module - one & two.
Basically, both of them are QA findings about random hashes sometimes being added to the end of filenames (that's what the detault storage back-end does in case when a file is uploaded with existing name).
In order to fix this, we've added this mixin which creates a sub-folder with hash name, which keeps the original file names.
However, it is probably an overkill for this case - which makes things more complicated than they should be.
I think we'll remove this code, and will mark this ticket as wont-fix:
https://trello.com/c/3o1mUZ4t/122-random-text-appearing-at-the-end-of-an-attachment
@ntrncic sounds good?
from etools.
Related Issues (20)
- Optimize CostAssignment synchronizer
- WBS / Delegate performance increase - Backend HOT 1
- WBS / Delegate performance increase - Frontend HOT 1
- TA NOT required flow change. HOT 1
- Expose (secure) API's to PRP for syncing some data
- List PD SSFA endpoint for PRP
- PRPResultSerializer
- setup Demo for PRP-integration HOT 1
- Remove Hstore HOT 4
- Add API EP for workspaces
- PRP-refactoring
- Conflicting views for deleting ResultLinks
- API changes related to sync PMP -> PRP HOT 17
- Organize users views
- Milestones list endpoint inaccessible HOT 1
- Vision synchronizers with GLOBAL_CALL = True use incorrect URL
- Data quality check on PRP data sync API for Partner HOT 2
- Initial Update
- Initial Update
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from etools.