Comments (6)
This is too bad. I had this kind of data loss before and it's really frustrating. I don't understand how this script could survive for years without this side-effect being detected.. Thank you for the report.
I plan to do like this:
- Do a hot-patch on privacy.sexy web version. Remove this script until real fix is there.
- Work on real fix, align the behavior to be same as Linux configuration, i.e. do not recommend the script at all, document properly and remove files selectively instead of iterating every file.
- Then later in future, in next minor version i.e.
0.13.0
, I will do an improvement to how collection files are loaded. I will allow scripts to be shared throughout all three OSes. This way, Firefox configurations and similar can be same on all operating systems. I want to start working on 0.13.0 but the fixes get the most priority so I haven't been able to reach the point of adding new features for months..
from privacy.sexy.
Thanks, I didn't know the documentation was already mentioning this for the Linux variant. But it doesn't seem like it handles it any different, though.
If you really want to provide this properly, it would need SQL queries (on Windows e.g. with https://sqldocs.org/sqlite/sqlite-with-powershell/).
Otherwise, my personal belief is that it would be better to not provide this option at all, instead of having it "half-assed" and potentially user data destroying. Even if it is documented, like for the Linux implementation. There are lots of other tools that do handle this properly, so best to use one of those then.
from privacy.sexy.
I've played around with the implementation on Linux, and it's working alright (see CleanTableFromFirefoxProfileDatabase
). The code is orphaned, not used, and it deletes the entire table. Better queries would be needed for some operations.
macOS and Linux (most major desktop distributions) come with SQLite and python by default, making life easier. For Windows, as you pointed out, a separate SQLite installation is needed. This discussion PowerShell/PowerShell#6050 provides another option too. So we could install it/run the query/uninstall.
So we can edit places.sqlite
without touching bookmarks. But I do not have time to implement this for now. So as you say, two options: get rid of the script completely, or keep it but in isolation. I use this kind of cleanup when I will hand-over a computer to someone else or after someone else uses my computer. So there's a use-case for it: easy quick cleanup. I think there's value in giving a quick way to get rid of the data for now.
But on the other side this script should not cause any unexpected data loss without expectation.. So I guess not including it any recommendation pool, and document it properly on title that it deletes bookmarks would be fine. I also plan to add red light icon to unrecommended scripts, green to recommended, yellow to strict in 0.13.0 to highlight that.
I don't dictate but provide my opinions so I'm still open to any ideas.
from privacy.sexy.
Yeah it's pretty unfortunate that on Windows there's no native support for sqlite in this case. Other than that, I don't think there's a real solution, though.
from privacy.sexy.
Fixed and released in 0.12.6 🚀 I know that this is not the ideal solution we want, but it's better documented/safer implemented and not recommended anymore.
from privacy.sexy.
Good improvement nonetheless. Thanks!
from privacy.sexy.
Related Issues (20)
- [BUG]: Snipping Tool still can be executable via its keyboard shortcut HOT 9
- [BUG]: Remove Windows Apps doesn't fully remove Xbox Apps HOT 2
- [Feature] The search string as query parameters in the URL HOT 8
- [BUG]: When trying to copy a screenshot by sketching a fragment of the screen (ctrl+shift+s), copying does not happen automatically, an error occurs when trying to copy manually. HOT 4
- Disable Copilot keyboard shortcut (Windows key + C) HOT 5
- Apple silicon processor support HOT 11
- [BUG]: After applying Standard selection Phone Link is broken HOT 9
- [BUG]: Error Running Script HOT 3
- [BUG]: Something in standard script selection breaks "Forgot my password" on the lock screen
- [Feature] Overall Preview Report Of Privacy HOT 10
- Cannot Login & Windows Event Log service HOT 2
- [BUG]: Cannot Login and Windows Event Log service HOT 5
- Reduce display/screen fingerprinting HOT 1
- [BUG]: Search is still broken even after restore HOT 4
- 0.13.3 DMG on Mac only contains the ARM64 version HOT 2
- Hyper-V VM connection issues after running "Standard" HOT 5
- [BUG]: FYI : Disable "Windows Defender Firewall" service also break Windows Sandbox. HOT 4
- [BUG]: WhatsApp (UWP) not starting HOT 1
- desired state / parsing of generated scripts or separate config HOT 1
- How to switch the program language? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from privacy.sexy.