Please fix multi-line URLs in templates about blizzhub-ts HOT 7 CLOSED

Maybe, i currently use debian to develop some of my major libs.
I'll make asap a fix for this, thanks for sharing it

from blizzhub-ts.

Just noticed the project is in TypeScript, so the issues will need to be fixed there. For instance:

        getApiHero = (region: string, bnet: string, heroId: string, locale: string): Promise<JSON | ApiException> => {
            return HttpRequest.get(`https://${region}.api.blizzard.com/d3/profile/${bnet}/hero/${heroId}
                ?locale=${locale}&access_token=${this.token.identifier}`)
        }

will become:

        getApiHero = (region: string, bnet: string, heroId: string, locale: string): Promise<JSON | ApiException> => {
            return HttpRequest.get(`https://${region}.api.blizzard.com/d3/profile/${bnet}/hero/${heroId}?locale=${locale}&access_token=${this.token.identifier}`)
        }

Thanks :)

from blizzhub-ts.

Hi thanks for noticing that but when i used to test the API it was working and the new line was not being counted as a new line but i'll make them inline

from blizzhub-ts.

No worries, and thanks for getting this library up and running, I was pretty close to trying to make one myself before I found this!

Perhaps this is a Windows vs Mac/Linux line ending issue? I am on Windows (I also have a Mac, but haven't tested this there just yet).

from blizzhub-ts.

Sorry for delay, i've updated this path problem just take a look at new update

from blizzhub-ts.

Hi there, you missed one! Check the getApiHero method of diablo3.js.

from blizzhub-ts.

The issue is fixed, thanks for the report 👍

from blizzhub-ts.