SuiteSetUp colored yellow in test summary about fitnesse HOT 7 CLOSED

Hi,

I think I just corrected this (#52). I feel the setup page should not contain any (functional) test. It's still counted as an ignored page though.

from fitnesse.

great!

from fitnesse.

Hi,
While the SuiteSetup page is now green in the test results, the test summary still shows 1 ignored page. Is this the intended behaviour? ie - this this what is meant by the comment "It's still counted as an ignored page though."?
Would it not be preferable to treat it the same as a Setup page?
Thanks.

from fitnesse.

Yes it is :)

I kept that as is. I found that not too much ignoring, since the test will make the result bar turn green. Changing this is slightly more involved.
A setup page is included (as in: literally included in the to be executed page). So the behaviour is different from the start.

from fitnesse.

OK - thanks.

Our build server (Jenkins) processes the XML response, and marks the ignored test as yellow. Would you expect applications that process the XML to implement the same logic as your fix, or do you expect the slightly more involved solution will be investigated at a later stage?

I have implemented a work around by transforming the XML before delivering it to Jenkins, but it feels a little dodgy.

Thanks.

from fitnesse.

Hi,

It was a little more coding than I expected. Now if a SuiteSetUp/TearDown contains no tests it's colored green (pass) and is counted as a "right" test case. Also the logic for test pages and test history is unified.

Regards,

Arjan

from fitnesse.

Looks awesome - thanks very much!

from fitnesse.