Comments (10)
I would be concerned about backwards compatibility - there may be tests that rely on the rendered value appearing in the table cells.
from fitnesse.
I understand your concern, but in this case, the result depends on the style applied or the comment written : how could someone think this would be robust ?
In any case, we could offer this enhancement without changing existing widgets : one could add his own, which allow a more simple and more robust comparison.
from fitnesse.
I'm not really clear on this.
Do you mean that, if you have a table
| check | some value | !note a comment |
| check | url | http://fitnesse.org |
SliM compares the output of someValue()
with <span class="note">a comment</span>
and the output of url()
with <a href="http://fitnesse.org">http://fitnesse.org</a>
?
from fitnesse.
I don't know what really happens. Maybe Slim compares with "!note a comment" but the results get interpreted after.
Here is my Test class :
public class Test {
public String someValue() {
return "";
}
public String url() {
return "http://fitnesse.org";
}
}
and the result I get : http://imageshack.us/photo/my-images/593/testzk.jpg/
using
|script|Test | |check |some value|!note a comment | |check |url |http://fitnesse.org|
from fitnesse.
Hi,
This doesn't look sound to me. What confuses me is that you want to check the output from the someValue()
call with a comment.
What you want is the ability to add additional comments to the lines in a script. For that you can also use | note |
command in the script table:
|script|Test |
|note |a comment about the next line |
|check |some value| |
|check |url |http://fitnesse.org|
At least, that's how I use it. I tend to make the note content bold ('''text'''
), so it is more visible.
from fitnesse.
Hi,
I don't want to compare to the comment, but that's what fitnesse does. Maybe if I put a value it's more understandable ? Suppose someValue() returns "someValue", the cell content would be "someValue !note this a comment explaining the value."
I know I can put additional note in a script table, that's not what I want : I want value comparison to be based on real content, not rendered one : do not take style into account, ignore comments, etc. You didn't mention the url example, don't you think the check url should pass ?
from fitnesse.
The point (problem if you like) is that tests are performed with the rendered wikitext (html). It looked weird to me when I saw that the first time (and the second time..).
I share Mike's concern about backwards compatibility, but yes: I would expect the url to pass.
A solution might be to define another test system (slim2
?). With the new parser we have a better grip on how tests are handled.
from fitnesse.
FitNesse has 2 separate components - a wiki that lets you compose web pages (HTML) in a wiki markup language, and a test execution component that lets you execute HTML tables as tests. So, SLIM never sees the wiki markup - it sees the rendered HTML. What you're proposing, while doable, would be a fundamental change to this separation of concerns.
To stop the url from being rendered as a hyperlink, you can write it as a literal !-http://blah.blah-!
from fitnesse.
Thank you for your answers. I guess this is not as easy as I thought, too bad :/. Should I close this issue ?
from fitnesse.
No one got back to you on this. I think we should close this. I'll go ahead and do that. It can always be reopened if someone feels there is a strong case and provides a possible approach.
from fitnesse.
Related Issues (20)
- Problem with delete Spcialisterren logo/image
- data:image/png;base64 HOT 1
- Java-11 compatible version of FitNesse is in Maven Central HOT 1
- Authentication - a little more options in the UI would help HOT 4
- I want to see each command immediately as it is being executed
- Running test suite with format XML stops at first date field in result HOT 3
- Can a template template access a markup variable whose name is argument to the table template ? HOT 2
- Need to disable adding new pages HOT 1
- Switching off the page and test history HOT 15
- When run Suite test, cannot read test history is not saved HOT 2
- fitnesse compile error how to fix it? HOT 7
- How to use conditional script? HOT 3
- Slim GracefulNaming, misleading documentation in the UserGuide HOT 8
- Starting fitnesse with ./gradlew run doesn't complete HOT 3
- [Question] How to get java for the latest version of fitnesse HOT 1
- Bootstrap 3 still being compiled HOT 2
- Heading anchor covered up by top nav bar in bootstrap theme
- When will a new Version be released? HOT 2
- No SLF4J providers found when using the standalone version HOT 9
- Azure Active Directory / Entra ID support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fitnesse.