Comments (6)
Using the locale only from the context is just fine, it will ensure that the selected language i'm usually seeing is used which is also a supported language and primarily the default language when creating a new option or any other entity.
If we'd change this, we'd need to enable this for all other "Create Text Input Types" for ex. CreateProductVariationInput, CreateProductVariationOptionInput, CreateProductInput, CreateAssortmentInput.
To add another localized string to an option it's this here with providing the filterOptionValue (UpdateFilterTextInput has locale):
"""
Updates or created specified filter texts for filter with ID provided and locale and optionally filterOptionValue
"""
updateFilterTexts(
filterId: ID!
filterOptionValue: String
texts: [UpdateFilterTextInput!]!
): [FilterTexts!]!
from unchained.
I think the way it is now it's consistent and changing all of the other types is a bit too much for the benefit.
from unchained.
@pozylon we need it to implement this case https://github.com/xecutors/unchained-adminui/issues/488#issuecomment-2100044334 otherwise when adding a new text it will always default to context locale
from unchained.
from unchained.
@Mikearaya please add all of our discussed requirements to a ticket and open a new PR once you have it working
from unchained.
or yes, use this one ^^
from unchained.
Related Issues (20)
- Extend the failed scheduler to allow retrial customization HOT 1
- GridFS Plugin ignores mime type of URL download response even when filename invalid or has no mime-type HOT 1
- Allow Bulk Import to download images of untrusted self-signed sources HOT 1
- Worker is not defaulting to hostname as worker HOT 1
- rescheduleWork does not cancel the old schedule HOT 1
- Improve Re-Scheduling Behavior of Auto-Scheduled Jobs HOT 1
- Improve Cache Invalidation Behavior
- Bundles should have their own prices and warehousing
- Discount total amount is always net
- A filter that returns 0 products does not tag the options provided as "isSelected" even though it's explicitly in selection HOT 1
- [FEATURE REQUEST] Add a validation step on mutation resolvers HOT 1
- Can't subscribe to product upsertLocalizedText operation
- Add a status API that returns monitoring-relevant information HOT 1
- [FEATURE REQUEST] Enable User deletion HOT 1
- MongoDB Validator instead of Simpl Schema HOT 1
- Integration tests for plugins lack webhook coverage and certain payment plugins
- [FEATURE REQUEST] Check Reset Token for Validity upfront
- Integrate "Events" more deeply into Unchained
- Restricted file downloads HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unchained.