BarrageClock never got released. about barragerenderer HOT 12 CLOSED

I committed a new version 1.8.0, you can try this.

from barragerenderer.

I have tried the new version(1.8.0).It doesn't work for this issue.And after I checked the codes u committed recently,I couldn't find the commit which fixed this issue.Could u show me the codes or the commit link?

from barragerenderer.

Which version did you use before? 1.7.0?

from barragerenderer.

Yes,1.7.0.And I tried the newest codes on branch master after you released version 1.8.0.
pod 'BarrageRenderer', :git => 'https://github.com/unash/BarrageRenderer.git'

from barragerenderer.

Take a look at my new PR #22

from barragerenderer.

this: 5ae4863

which fix a retain cycle in 1.7.0

And the commit was released in 1.8.0

from barragerenderer.

Yeah.I fixed the BarrageRenderer retain cycle issue by the same codes.
But this is another issue of BarrageClock.

from barragerenderer.

Have u got it?

from barragerenderer.

Does it appear in the demo?

from barragerenderer.

The demo couldn't reproduce this issue.Because the demo keeps a View Controller as root view controller all the time.And VC keeps BarrageRenderer instance all the time.

from barragerenderer.

I merged it into master branch.

from barragerenderer.

OK.I closed this issue.

from barragerenderer.