Wrong id in source_id about laravel-model-recommendation HOT 7 OPEN

Doing a fast search, that is how i fixed it, I'm not sure if it's the right way or I didn't hardcoded it:

public static function calculateRecommendations($data, $dataCount)
    {
        $dataCartesianRanks = [];
        $recommendations    = [];
        $dataGroup          = [];

        foreach ($data as $value) {
            if (!isset($dataGroup[$value->group_field])) {
                $dataGroup[$value->group_field] = [];
            }

            $dataGroup[$value->group_field][$value->data_field] = $value->data_field;
        }

        foreach ($dataGroup as $group) {
            foreach ($group as $data1) {
                foreach ($group as $data2) {
                    if ($data1 == $data2) {
                        continue;
                    }

                    if (!isset($dataCartesianRanks[$data1])) {
                        $dataCartesianRanks[$data1] = [];
                    }

                    if (!isset($dataCartesianRanks[$data1][$data2])) {
                        $dataCartesianRanks[$data1][$data2] = 0;
                    }

                    $dataCartesianRanks[$data1][$data2] += 1;
                }
            }
        }

        // Generate recommendation list by sorting
        foreach ($dataCartesianRanks as $data1 => $data) {
            arsort($data);

            $key = key($dataGroup);

            $data                    = array_slice($data, 0, $dataCount, true);
            $recommendations[$key] = $data;
        }

        return $recommendations;
    }

from laravel-model-recommendation.

@Xoshbin many thanks for the issue and solution. Let me check and update you asap :-)

from laravel-model-recommendation.

@Xoshbin Is it possible to create a PR for this fix? Theoretically, It is correct. I will merge it soon.

from laravel-model-recommendation.

I will do a PR soon, I was waiting for your response for two things:
First: making sure the solutions is working! (Done)
Second: There is an issue!!
on the same use case and using my example, I think "it's supposed to iterate through the posts table to generate the recommendations" (correct me if I'm wrong), but it's generating the recommendations iterating through the interactions table .

from laravel-model-recommendation.

@Xoshbin I have merged PR but It fails agains the existing tests. When I checked, I think $key = key($dataGroup); is wrong. The $key is always the first index.

from laravel-model-recommendation.

@Xoshbin Regarding the second problem, It should traverse the interactions table to have the both source and target IDs.

from laravel-model-recommendation.

@Xoshbin I have merged PR but It fails agains the existing tests. When I checked, I think $key = key($dataGroup); is wrong. The $key is always the first index.

It's true, it's returning the first index. when I debug the issue, only the first index contained the source_id value, that is why I fixed it that way, it did fix my problem, but I was not sure if it was correct or no and that is why I waited for your response.

from laravel-model-recommendation.