Code Monkey home page Code Monkey logo

Comments (12)

mortenholmgaard avatar mortenholmgaard commented on August 25, 2024

I have the same problem

from umbraco-vorto.

mattbrailsford avatar mattbrailsford commented on August 25, 2024

As there is no official documentation on how property editor developers should handle the preview mode of the new doc type editor, anything we implement would technically be a hack. Given this doesn't break functionality at all, it just doesn't look nice for the developer, my thoughts are to hold of till there is some official guidance on how these should be handled.

from umbraco-vorto.

craigs100 avatar craigs100 commented on August 25, 2024

Don't know if this is a step too far or not related but the content in an RTE in a Grid in Vorto doesn't survive the first language switch. i.e. fr to de ok, back to fr, RTE broken (html showing).

from umbraco-vorto.

mattbrailsford avatar mattbrailsford commented on August 25, 2024

from umbraco-vorto.

Shazwazza avatar Shazwazza commented on August 25, 2024

My thoughts are that previews (if required) it# should simply be done by css targeting, this might even be possible without any core changes now?

from umbraco-vorto.

mattbrailsford avatar mattbrailsford commented on August 25, 2024

from umbraco-vorto.

abjerner avatar abjerner commented on August 25, 2024

As a developer of various property editors, a separate view for the preview seems like a good idea to me.

Alternatively we can do some extra checks in the controller of the individual property editors, but right now that would probably be checking if the property editor is within an element with a certain class (that is, hacky at the moment).

Possible there could be an optional config parameter for a preview view, which gives developers some separation between the primary view and the preview view. If not specified, it would be up to the developer to handle the preview in the primary view (or it's controller).

I understand that there might be more important stuff in the pipeline, but some documentation on this would be awesome.

from umbraco-vorto.

Shazwazza avatar Shazwazza commented on August 25, 2024

There is no "documentation" because this isn't something that was really considered.

A feature request needs to be created (if one doesn't exist already) and we can discuss ways to implement it..... But I don't see what a separate view achieves over just targeting css classes. You can toggle display on/off with this approach which achieves the same thing (and it might actually work as it is today)

from umbraco-vorto.

mattbrailsford avatar mattbrailsford commented on August 25, 2024

from umbraco-vorto.

Shazwazza avatar Shazwazza commented on August 25, 2024

Ok cool, well we'll support both ways, I think for many devs it will be just easier to style but if devs need advanced stuff we can register a preview view

from umbraco-vorto.

mattbrailsford avatar mattbrailsford commented on August 25, 2024

For sure, my main thing is just to have an official method of doing either, rather than devs just finding ways and means like we usually do :)

I've raised the feature request here http://issues.umbraco.org/issue/U4-8244 so I'll close this issue for now and continue the discussion there as I don't feel any point implemented an interim hack

from umbraco-vorto.

AngelRazoJ avatar AngelRazoJ commented on August 25, 2024

I have the same problem
what is solution?

from umbraco-vorto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.