Code Monkey home page Code Monkey logo

Comments (9)

klawdyo avatar klawdyo commented on June 16, 2024 1

You can implement this filter only in API. It would be an advanced option.

from umami.

klawdyo avatar klawdyo commented on June 16, 2024 1

One more thing.
In this example: one website managing multiple subdomains.

The "open in new tab" button link displayed in this list is wrong
image

  • I think the hostname used in this list should be the one in the session, not the one in the website registration.
  • I also think the page icon could be displayed in this list. In cases where they are the same "hostname", nothing would change, but it would look better with the pages' favicon. But in the case of multiple sub-domains, it would help a lot.
    Example, like referrers icons:
    image
    All other lists on the page show the icon. It would be more standardized.

from umami.

franciscao633 avatar franciscao633 commented on June 16, 2024

We already store hostname in the session table so it wouldn't be too hard to implement. Were you looking for hostname as its own metric card and filter? Users that don't use subdomain would just see a single record like umami.is which would be pretty useless. I guess we can make it configurable where the default would be to disable it.

from umami.

giuseongit avatar giuseongit commented on June 16, 2024

I actually already implemented this feature in #2689, I just need someone to review my code

from umami.

giuseongit avatar giuseongit commented on June 16, 2024

The only thing that is missing is the ability to make it configurable, but for that I'd like some help since I've never worked with next.js

from umami.

franciscao633 avatar franciscao633 commented on June 16, 2024

@giuseongit Thanks well take a look. I think were leaning towards just an API change, but if adding a configurable host card makes sense we'll implement.

@klawdyo adding a bug tag. page links should work with subdomains. Thanks for reporting.

from umami.

klawdyo avatar klawdyo commented on June 16, 2024

@giuseongit Thanks well take a look. I think were leaning towards just an API change, but if adding a configurable host card makes sense we'll implement.

I think if have many hostnames, make sense show them. Maybe this checking can be better than a config.

@klawdyo adding a bug tag. page links should work with subdomains. Thanks for reporting.

Just remember group pages by hostnames on SQL, because some pages are common between them.
Example:
Screenshot_20240429-140301.png

  • blue are specific by hostnames
  • yellow are common at all

So "/", for example, should be displayed one time for each hostname.

from umami.

snaildos avatar snaildos commented on June 16, 2024

bump - wish this feature was added and integrated just like refers.

from umami.

rishabhAjay avatar rishabhAjay commented on June 16, 2024

I second this. A card that shows the hostnames and a hostname filter while reporting would be really useful for applications using a lot of subdomains.

from umami.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.