Comments (7)
Just tell if its interesting that i make a PR into this repo from this MaindeckAS@a8425b3
from limiter.
Hello,
As described here (https://github.com/ulule/limiter#limiter-behind-a-reverse-proxy) you should use what is best for your network topology. That's why it's disabled by default.
But word of caution, if you use the rightmost IP in the header you could rate limit your load balancer or CDN.
Just tell if its interesting that i make a PR into this repo [...]
No thank you, I plan to make a customizable system for the next major version.
I just need to find the motivation for this, I haven't been active recently.
from limiter.
But thank you for mentioning your fork, I may use it when (or if) I'll implement a rightmost ip parser.
from limiter.
But word of caution, if you use the rightmost IP in the header you could rate limit your load balancer or CDN.
No, because aws alb appends client ip to XFF header. I dont know from where you have this idea, but its not valid in aws :) but no stress
from limiter.
btw the most funny part is i might not need to use this fix at all. Because i made a middleware that fixes XFF header to rightmost. So i can use all kinds of libraries like this without caring too much
from limiter.
No, because aws alb appends client ip to XFF header. I dont know from where you have this idea, but its not valid in aws :)
As said before, that depend of your network topology: not everyone use AWS.
You could have an nginx with a public ip and then other nginx inside a VLAN, private network or an hypervisor that routes that to the correct VM / containers.
from limiter.
Yep, you are right :) Ill close this now, but feel free to use as inspiration, or not. I am currently using another solution for this problem.
from limiter.
Related Issues (20)
- Change limiter rate on the fly HOT 2
- Is there any way to skip rate limit and keep service available even store crashed? HOT 2
- Does this project support redigo HOT 2
- Builds fail when using gomod HOT 2
- work behind load balancer HOT 4
- Should be flexible enough to support advanced use-cases HOT 4
- Per-route limiting HOT 2
- Reintroduce Ping function to the Client interface HOT 3
- Feature Request: Please can you add rqlite as store HOT 2
- Limit for every 5 minute HOT 1
- Please consider adding SkipList option HOT 1
- Rate limiting based on custom identity HOT 2
- ERR bad lua script for redis cluster HOT 1
- Which time windows does this limiter use? HOT 1
- Custom keys? HOT 1
- limit of dynamic route HOT 1
- another dynamic limit need HOT 9
- Limiters with momery store are not working as expected HOT 3
- A key can be limited forever HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from limiter.