Code Monkey home page Code Monkey logo

Comments (14)

UlrichRaab avatar UlrichRaab commented on July 22, 2024

Hello, can you provide an example of a contact that you do not get? It also would be nice to know what device and Android version you are using.

from rx-contacts.

Pahanuch avatar Pahanuch commented on July 22, 2024

Samsung Galaxy J3
Android 5.1.1

Any contacts. For example +7 926 987 65 43 (without spaces). But If I add more then one phone number, problem is gone. But first number always skips. So for example: I created contact (Maria). And Added 3 phone numbers (555 555 555, 666 666 666, 777 777 777). Last couple will be is available, first - skips.

from rx-contacts.

Pahanuch avatar Pahanuch commented on July 22, 2024

I'm sorry. But when you can fix it ?

from rx-contacts.

UlrichRaab avatar UlrichRaab commented on July 22, 2024

I need to get a samsung device to be able to test. I tried it with my Nexus 5 and i dont have the issue. I already called a fried who owns a old samsung device and he will send it to me this week so that i can start fixing this.

from rx-contacts.

Pahanuch avatar Pahanuch commented on July 22, 2024

I think the problem is not in device. I tested it on Emulator (Android 6.+).

from rx-contacts.

pnickv avatar pnickv commented on July 22, 2024

I see the same issue

from rx-contacts.

pnickv avatar pnickv commented on July 22, 2024

it looks like the issue is for emulators only

from rx-contacts.

Pahanuch avatar Pahanuch commented on July 22, 2024

I get this issue on real device too

from rx-contacts.

UlrichRaab avatar UlrichRaab commented on July 22, 2024

I could reproduce the issue in a Samsung Device and will try to fix it asap. I hope i can Start working on it on sunday.

from rx-contacts.

Waterbyte avatar Waterbyte commented on July 22, 2024

Under private void fetch (Subscriber<? super Contact> subscriber) {....} in RxContacts.java, Please add
mapPhoneNumber(cursor,contact,idxData1) even if contact isn't present to resolve this issue. In your condition, you are adding Phone number and Email only if contact details are present before. That's why first one is always skipped.

from rx-contacts.

UlrichRaab avatar UlrichRaab commented on July 22, 2024

@Waterbyte Your bugfix looks good. I could test it on a Nexus 5X and want to test it on some other devices. I will do this tomorrow. I pushed the change to the dev branch in case you want to test by yourself.

Thank you

from rx-contacts.

UlrichRaab avatar UlrichRaab commented on July 22, 2024

I could test it on a Samsung Galaxy S8 and a HTC 10. It looks like the bugfix is working. I will publish the new version today.

from rx-contacts.

UlrichRaab avatar UlrichRaab commented on July 22, 2024

I have published the new version of RxContacts (1.1.3) and will close this issue.

from rx-contacts.

Waterbyte avatar Waterbyte commented on July 22, 2024

@UlrichRaab Nice, Thanks for the Library.

from rx-contacts.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.