Code Monkey home page Code Monkey logo

Comments (2)

xenatisch avatar xenatisch commented on June 11, 2024

There are two issues here.

  1. I agree that there needs to be an example. It used to have one, not sure why or when it was removed.
  2. I will not be allowing invalid postcodes. The service has been tested with 100s of users and is used by million each week. Processing a variety of postcodes would bypass the CDN cache and the API cache - i.e. 2 of the 3 caching layers - and put unnecessary pressure on the service. Considering that the service sustains between 50 and 70 million requests a day, it stands to reason to take measure to mitigate the traffic in anyway possible. Generic guidelines do not usually cater for all circumstance.

I do not usually respond to such issues on GitHub as they are not specifically related to development. However, I am doing so on this occasion because you have taken the time to provide a nicely structured issue, so I shall return the courtesy by taking note of your kindness.

Thank you.

PS: We regularly work with the GDS, because as I am sure you have noticed, our design does not entirely conform to their guidelines.

from coronavirus-dashboard-frontend-server.

terrysimpson99 avatar terrysimpson99 commented on June 11, 2024

Thanks for your response. I'm a bit confused by the response to my comment about html5.
I wrote: '1. The postcode field uses html5 validation. GDS guidance says: "Turn off HTML5 validation"'
You wrote: '1. I agree that there needs to be an example. It used to have one, not sure why or when it was removed.'

My comment wasn't about an example, it was about html5 validation.
Trying to help.

from coronavirus-dashboard-frontend-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.