Comments (3)
Interesting. I also like that it would speed up email sending in views even more. How would you persist the template context though? I think it also depends on the use case if this is useful or not, and should be optional.
from django-post_office.
Yes, it will be optional. The API I had in mind looks like:
from post_office import mail
mail.send(
# Other options...
template=my_template
context={},
render_on_delivery=True
)
Email
s created with render_on_delivery
(better name suggestions welcome) will be stored with a ForeignKey to EmailTemplate
so content can be rendered during delivery. A context
or context_data
field (presumably JSON serialized) to email for rendering at a later time.
If JSON is used, however, we won't be able to store complex Python objects like Django model instances so perhaps at a later date we can introduce a different serializer (pickle maybe?).
from django-post_office.
Fixed in fb426ad
from django-post_office.
Related Issues (20)
- Already rendered Email is re-rendered without context HOT 2
- jQuery $ is not available in Django admin by default
- Emails are rendered without context data HOT 2
- E-Mail subject rendered without context in E-mail admin list view
- Add reply_to attribute to mail.send() HOT 1
- [QUESTION] Can I still use my own smtp email backend?
- Django 4.1 compatibility HOT 8
- When using celery emails are not sent directly HOT 8
- MEDIA_ROOT not documented
- Post-office raise 2 same error when there are SMTP connection error HOT 1
- dictionary update sequence element #0 has length 1; 2 is required
- Authorisation fails for Office 365 with new default policies in place HOT 4
- Commit aa1617e creates issues when creating a new email where context is also set. HOT 2
- Mocking email template for tests
- Bleach is deprecated as of 2023-01-23 HOT 1
- Can Templates include sub-Templates? For example, consistent signature/unsubscribe footers HOT 1
- Suggestion: Minimal support for implementing retention policies HOT 1
- Spanish translations
- Create New Email From Django Admin HOT 3
- insanely hard to edit default content for a template HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-post_office.