Feature request: Add min/max parameters about react-dynamic-number HOT 5 OPEN

Implementation doesn't look too hard. But I have objection how it should work.
For example you set min value to 1234,12345. Now user want to type value 99. To do this he type first number 9. Directive doesn't know when value is typed, it just checks actual value. Therefore it checks if value 9 is bigger then min value. And it isn't. What then? Less problematic is max value but I also see UX problems.

from react-dynamic-number.

Maybe we could start with just adding the max value feature for positive numbers, and a min value feature for negative values.

from react-dynamic-number.

But as I wrote above, max value also has some controversies. For example if max value is 999.99999 and user want write 111 but by mistake write 1111 then it will change his value to 999.9999 and he need to remove it totally. Max and min value are cool when user writes value and then for example presses submit button. Not when he dynamically write it.

But this is my opinion. If you will write some accurate arguments then very likely you will convince me. Because I try to make this modules as good as possible (taking into account my free time :) )

from react-dynamic-number.

+1 for max

from react-dynamic-number.

I think, that min, max is solely the validation concern, so it should not be solved in this way. The validation is a business logic - specific concern and should be handled by your application. Usually, it involves adding "visited" boolean flag, which indicates whether your control has been touched by user input or not. And the validation is executed in onBlur event and explicitly, when user saves the form.

from react-dynamic-number.