Code Monkey home page Code Monkey logo

Comments (3)

ueman avatar ueman commented on May 28, 2024 1

Yeah, no worries. We all gotta start somewhere.
The changelog step failed because you didn't add an entry to it.
It's not that bad and can be merged when all other steps are successful.
I can take over frome here.
Thanks again 👍

from feedback.

ueman avatar ueman commented on May 28, 2024

Hey, thanks for raising this. I think I agree with you and dismissing the keyboard on enter is probably the better default. Are you interested in doing a PR? It seems like you already changed it anyway. I would gladly guide you through it if you need any help.

from feedback.

reju1021 avatar reju1021 commented on May 28, 2024

I've never done this before :D. I gave it a try and submitted a new pull request. I've built it locally and it works (could only test iOS so far.)

Edit: It says the task "changelog" has failed. Do I have to write anything in the changelog or is it not important and the PR is still mergeable?

from feedback.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.