Code Monkey home page Code Monkey logo

Comments (10)

ilyasarafath avatar ilyasarafath commented on September 27, 2024 2

@JesusHdez960717 It is working fine

Screenshot 2024-04-03 at 2 33 35 PM

from feedback.

EM-Sabeel avatar EM-Sabeel commented on September 27, 2024 1

@ueman @JesusHdez960717 I also facing this issue. The above issue not working.
@ilyasarafath did find any solution

from feedback.

JesusHdez960717 avatar JesusHdez960717 commented on September 27, 2024 1

hi @ilyasarafath, the PR that solves this bug is finally merged, if you want test it again to make sure and in case the bug is not reproduced any more, feel free to close this issue

from feedback.

ilyasarafath avatar ilyasarafath commented on September 27, 2024 1

It is working fine in latest version 3.1.0
So closing this ticket - @JesusHdez960717

from feedback.

ueman avatar ueman commented on September 27, 2024

So you have some code I can just copy paste and try? Even though your description is very detailed, it doesn't have enough information for me to be able to reproduce it.

from feedback.

ilyasarafath avatar ilyasarafath commented on September 27, 2024

Please check this sample app https://github.com/ilyasarafath/test-feedback

from feedback.

ilyasarafath avatar ilyasarafath commented on September 27, 2024

Also if alert dialogue is opened and try to click device back button the dialogue is still visible and page under dialogue is got popped .
I updated the code in same above repository . Pease check

from feedback.

JesusHdez960717 avatar JesusHdez960717 commented on September 27, 2024

@ilyasarafath could you plz try to reproduce this bug with the latest changes in the branch of the PR #293, this brach

I have the hunch that it has to do with the same bug (i have not test it myself, sorry, don't have the time)

from feedback.

ilyasarafath avatar ilyasarafath commented on September 27, 2024

@ueman Can you merge this PR and add to feedback_sentry plugin ?

from feedback.

JesusHdez960717 avatar JesusHdez960717 commented on September 27, 2024

Hello @ilyasarafath, thanks for the round of testing on this issue.

Unfortunately, although the solution proposed in PR #293 resolves this issue and some others related to dialogs and navigation in general, it also generates some strange behavior.... such as in the case of using a dialog in the custom feedback , this is only displayed at the bottom...

Considering this, we are still looking for the best possible solution to the problem, a solution that solves the problem without generating these strange behaviors and even more so, avoids possible new errors in the future.

BTW, in the PR there are more details, examples and screenshots of what is happening

from feedback.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.