Code Monkey home page Code Monkey logo

Comments (5)

willGraham01 avatar willGraham01 commented on September 7, 2024

This was closed with #262, not sure why it didn't auto-close when linked.

from tdms.

giordano avatar giordano commented on September 7, 2024

not sure why it didn't auto-close when linked.

Because it wasn't linked?

image

from tdms.

willGraham01 avatar willGraham01 commented on September 7, 2024

It was linked in #299, which then got merged into #262.

Although saying that, #299 looks like GitHub didn't auto-link this issue from the PR text anyway

from tdms.

giordano avatar giordano commented on September 7, 2024

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Note: The special keywords in a pull request description are interpreted when the pull request targets the repository's default branch. However, if the PR's base is any other branch, then these keywords are ignored, no links are created and merging the PR has no effect on the issues. If you want to link a pull request to an issue using a keyword, the PR must be on the default branch.

Emphasis not mine.

from tdms.

samcunliffe avatar samcunliffe commented on September 7, 2024

Yeah. Also, it's not solved because it's not solved.
Like on main.

from tdms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.