Comments (5)
From a user standpoint, I also find it weird that FixedPoint is a chisel3 thing vs. DspReal is a dsptools thing.
Also, one would think that DspReal and Real are similar, except Real is more like Ring vs. DspReal is more like FixedPoint, SInt, etc.
from dsptools.
One of the motivating factors in the choice of binaryPoint was the desire to support binaryPoints that were negative indicating a virtual exponent. I agree where the various players here (FixedPoint, DspReal) seems a bit arbitrary, but the short term decision was based on how fundamental FixedPoint needed to be in order to properly support it. So it became part of chisel/firrtl, the real stuff was supported by the BlackBox/ExternalModule for chisel/firrtl and did not require any changes. The utility of easily fungible Real/Fixed might argue to bring the real implementation down, but it does not seem to be on the short term critical path.
from dsptools.
@shunshou did you have a specific proposal in this issue? Change the name or simply better doc about the amibguities
from dsptools.
Sorry, ok I forgot about the negative binary points. But yes, if that's fine, please document. I just have to think about that every time I generate FixedPoint (back translate from what I'm used to).
from dsptools.
@chick I got confused again b/c "setBinaryPoint" = set # of fractional bits... Wasn't sure if it trimmed to the right # of fractional bits, shifted the binary point around, etc. etc. It's pretty confusing...
from dsptools.
Related Issues (20)
- DspContext with extra pipeline stages won't work for FixedPoint HOT 10
- dsptools/blob/master/rocket/README.md links not working
- DspComplex[T].zero not initialized HOT 1
- Instantiating constants of type DspComplex[DspReal] HOT 7
- Compilation fails in scala 2.12.8 HOT 2
- Pokeable Typeclasses for Testers HOT 1
- Remove updateDependencies script
- Document Width Relationships for Operations
- Add -D flag for rocket source dependency
- Is there any plan to update the SAM module? HOT 1
- Issue with TileLink ready-valid logic in TLMasterModel HOT 2
- Run-time failures for DspComplex isLit()
- Read the docs
- rocket-dsptools DmaSpec test failure with current rocket-chip
- Working with large FixedPoint and Intervals should use BigDecimal not Double
- Set precision in div2 fixedpoint and interval may have provblems
- Update the link to numeric classes description HOT 2
- Failing Tests on 3.4.1 HOT 1
- example code not working
- Library conflict HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dsptools.