Code Monkey home page Code Monkey logo

Comments (6)

gorhill avatar gorhill commented on May 22, 2024

Solution is probably to redirect to a transparent 1px image. I don't know how ABP does it, but that is certainly the simplest fix I can think of, which doesn't require playing in the DOM. I will try that sort of fix first and see what happens.

from ublock.

JBey4you avatar JBey4you commented on May 22, 2024

With v.0.1.0.6, there is some progress. Although, it's not 100% fixed. :-)

Here are two captures that show that a white space is still here (I underlined the space in question: http://i.imgur.com/yFTyjrr.jpg & http://i.imgur.com/bhHgbdb.jpg

But good job on this release!

from ublock.

gorhill avatar gorhill commented on May 22, 2024

Yes, the second part is the more challenging one, i.e. needs to put in infrastructure which doesn't exist yet (it didn't exist in HTTP Switchboard). I will have to think thoroughly to find the best way to implement this. Definitely possible, but I want to preserve efficiency advantage over other blockers.

from ublock.

kurtextrem avatar kurtextrem commented on May 22, 2024

ABP doesn't use the 1px thing. Adblock uses that. (ABP uses Shadow DOM, however that works https://adblockplus.org/blog/on-the-adblock-plus-memory-consumption#c005367)

from ublock.

gorhill avatar gorhill commented on May 22, 2024

I prefer to come up with my own solutions. I have various ideas, my point is that it's not going to be fixed as fast as the first part.

from ublock.

gorhill avatar gorhill commented on May 22, 2024

Sorry but due to issue #18, I had to move redirection to no-op content, so the collapsing of the DOM counterpart of a request is the only solution.

from ublock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.