Comments (3)
What C compiler and version are you using?
Could you try running CMake with -DWARNINGS_AS_ERRORS=OFF
and then compiling again?
from h3.
Interesting. It finishes compiling with the flag turned off. (so, yeah!) There are a few other complaints with that same sprintf() function in other files, but those were the only warnings.
gcc --version
returns gcc (SUSE Linux) 8.1.1 20180614 [gcc-8-branch revision 261584]
make --version
returns GNU Make 4.2.1 Built for x86_64-suse-linux-gnu
cmake -version
returns cmake version 3.11.4
libtool --version
returns libtool (GNU libtool) 2.4.6
I'm on SuSE Tumbleweed, which (I think) just recently moved from gcc7 to gcc8. ...I rarely compile things from source.
Ideas? I'm happy to keep digging if it might be helpful.
from h3.
Thanks for confirming it works and posting the version we need to test. Our CI tests and development systems aren't updated to GCC 8 yet.
H3 treats compiler warnings as errors by default, in an effort to catch code issues quickly. An unfortunate effect of this is that new compiler versions or different compilers can cause failures to compile the library.
In addition to testing on GCC 8 and resolving its warnings about sprintf, a good approach might be to set -DWARNINGS_AS_ERRORS=ON
in our CI tests, but default it to OFF
when being compiled by a user.
from h3.
Related Issues (20)
- cell_to_child_pos() version 4 of the Python API client HOT 3
- polygonToCells: validity of polygons HOT 3
- Missing library stubs MYPY HOT 2
- polygonToCells not returning all H3Cells for the bounding box containing both USA and Russia HOT 1
- Confirmation of grid algorithm HOT 3
- cellToChildren error HOT 2
- Add function for returning the H3 indices of each endpoint of a directed edge HOT 5
- Expose cellToChildrenSize in bindings HOT 1
- Getting unexpected results when converting coordinates in either direction HOT 4
- Meta: blog post has broken images HOT 5
- API | distance between h3s challenging to work around HOT 5
- Example H3 data sets HOT 3
- Completely cover a polygon with H3 cells using H3 extension for PostGIS
- Hi
- H3 Bug - Easily Reproducible HOT 1
- cellToVertex result seems to be incorrect? HOT 3
- Issue with H3: Uberβs Hexagonal Hierarchical Spatial Index HOT 2
- can't use the h3 gem in ruby using windows HOT 2
- FP exception handler triggered on both x86 and aarch64 HOT 10
- novice h3-js lib installation&test issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from h3.