Comments (4)
On Windows you can't go with C99, you have to go all the way back to C89 if you want to use Microsoft's C compiler and not fake it as a C++ project, which we weren't willing to do.
For other platforms, we saw no problem between targeting C99 and C11, so we simply chose the later standard in case we needed things like the memory alignment directives for mobile (we didn't, but that was one of the reasons).
from h3.
Really? I thought even Microsoft caught up to C99 by now. No worries either way, just noticed a bunch of C89 style code in here. Variable declarations at the top of the function, no use of variable length arrays (see #32) . Was wondering if it was intentional.
from h3.
@sahrk built the original core of this library, which has a loose connection to DGGRID, and that code is C89, so that's where that came from. We have refactored code and modernized it when digging into it, but we haven't attempted to systematically do so.
from h3.
Got it. Thanks.
from h3.
Related Issues (20)
- Broken Link to website docs in contributing.md
- Broken link to website in contributing docs
- Uber CLA Contact HOT 1
- Has cell_to_vertex been implemented? HOT 2
- Replace empty function parameters with `void` HOT 1
- cell_to_child_pos() version 4 of the Python API client HOT 3
- polygonToCells: validity of polygons HOT 3
- Missing library stubs MYPY HOT 2
- polygonToCells not returning all H3Cells for the bounding box containing both USA and Russia HOT 1
- Confirmation of grid algorithm HOT 3
- cellToChildren error HOT 2
- Add function for returning the H3 indices of each endpoint of a directed edge HOT 5
- Expose cellToChildrenSize in bindings HOT 1
- Getting unexpected results when converting coordinates in either direction HOT 4
- Meta: blog post has broken images HOT 5
- API | distance between h3s challenging to work around HOT 5
- Example H3 data sets HOT 3
- Completely cover a polygon with H3 cells using H3 extension for PostGIS
- Hi
- H3 Bug - Easily Reproducible HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from h3.