Code Monkey home page Code Monkey logo

Comments (6)

tonycosentini avatar tonycosentini commented on May 19, 2024

What about just advising people to potentially non-fatal them in their own onError plugin implementation?

from autodispose.

AttwellBrian avatar AttwellBrian commented on May 19, 2024

A. If the delegate doesn't implement onError, it goes to RxJavaPlugins and one could filter that in a plugin hook. This would not cover cases where onError is implemented though. Is this fine?

I can't think of a reason this wouldn't be fine. It was good enough for us? Do other companies implement onError() more than us?

from autodispose.

tonycosentini avatar tonycosentini commented on May 19, 2024

After syncing with @hzsweers in person, one idea is a plugin system for AutoDispose itself. The default implementation would just route to onError like it does currently, but would allow for custom handlers (for logging/non-fatals or whatever else makes sense for a specific app).

from autodispose.

ZacSweers avatar ZacSweers commented on May 19, 2024

Cool, plugin system sounds good. @tonycosentini do you want to start a PR around that? Structure would probably be best in the same vein as RxJavaPlugins

from autodispose.

tonycosentini avatar tonycosentini commented on May 19, 2024

Yup, will give it a shot.

from autodispose.

ZacSweers avatar ZacSweers commented on May 19, 2024

Done in #57

from autodispose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.