Code Monkey home page Code Monkey logo

Comments (12)

yhan818 avatar yhan818 commented on July 20, 2024 1

For requirements.txt:

ldap3==2.6.1
numpy==1.23.0
redata>=0.4.2

In addition, need to update file "setup.py"

from requiam.

zoidy avatar zoidy commented on July 20, 2024 1

".travis.yml " needs to be updated.

We don't use Travis CI anymore. https://requiam.readthedocs.io/en/latest/continuous_integration.html This file could probably be deleted

from requiam.

yhan818 avatar yhan818 commented on July 20, 2024

/requiam/org_code_numbers.py uses np.zeros(), which has no change from the numpy 1.20.0 to numpy 1.23.0. OK.

from requiam.

yhan818 avatar yhan818 commented on July 20, 2024

"script_run" uses pandas to read "pd.read_csvI()" and "pd.DataFrame.from_dict()". Ok.

Current Pandas latest version is 1.4.3.
-- read_csv() has no changes.

-- DataFrame.from_dict() has slightly changes but has no impacts to the script.

Pandas 1.2.3 https://pandas.pydata.org/pandas-docs/version/1.2.3/reference/api/pandas.DataFrame.from_dict.html#pandas.DataFrame.from_dict

Panda 1.4.3 https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.from_dict.html#pandas.DataFrame.from_dict

From testing, upgrading pandas version from 1.2.3 to 1.4.3 requires to upgrade tabulate (0.8.3) to (>=0.8.7)

from requiam.

yhan818 avatar yhan818 commented on July 20, 2024

Need to update "redata-commons" as well for Python version and related stuff.

from requiam.

yhan818 avatar yhan818 commented on July 20, 2024

".travis.yml " needs to be updated.

from requiam.

yhan818 avatar yhan818 commented on July 20, 2024

"script_run" uses pandas to read "pd.read_csvI()" and "pd.DataFrame.from_dict()". Ok.

Current Pandas latest version is 1.4.3. -- read_csv() has no changes.

-- DataFrame.from_dict() has slightly changes but has no impacts to the script.

Pandas 1.2.3 https://pandas.pydata.org/pandas-docs/version/1.2.3/reference/api/pandas.DataFrame.from_dict.html#pandas.DataFrame.from_dict

Panda 1.4.3 https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.from_dict.html#pandas.DataFrame.from_dict

So, upgrading pandas version from 1.2.3 to 1.4.3 shall have no impacts.

I have tested Pandas yesterday, and found that Pandas relies on Tabulate newer version. So these dependencies (at least Pandas, Tabulate) shall be updated.

from requiam.

yhan818 avatar yhan818 commented on July 20, 2024

Currently Python 3.10 build will fail. see https://github.com/UAL-RE/ReQUIAM/runs/7081741135?check_suite_focus=true

because
"numpy.distutils is deprecated since NumPy 1.23.0, as a result
of the deprecation of distutils itself. It will be removed for
Python >= 3.12. For older Python versions it will remain present.
It is recommended to use setuptools < 60.0 for those Python versions.
For more details, see:
https://numpy.org/devdocs/reference/distutils_status_migration. "

Therefore, skip Python 3.10 for now.

from requiam.

zoidy avatar zoidy commented on July 20, 2024

While I'm ok with skipping the Python 3.10 build for now if it's broken, I'm a bit confused. The message says that for Python < 3.12 numpy.disutils will remain. So on paper, its deprecation should have no effect. I feel like I'm missing something here.

from requiam.

yhan818 avatar yhan818 commented on July 20, 2024

While I'm ok with skipping the Python 3.10 build for now if it's broken, I'm a bit confused. The message says that for Python < 3.12 numpy.disutils will remain. So on paper, its deprecation should have no effect. I feel like I'm missing something here.

see https://github.com/UAL-RE/ReQUIAM/runs/7081741135?check_suite_focus=true

Dependencies installation failed.

from requiam.

zoidy avatar zoidy commented on July 20, 2024

I see. I'm not fully convinced it's due to the disutils deprecation message though. In any case, I'm ok with removing the 3.10 test.

from requiam.

yhan818 avatar yhan818 commented on July 20, 2024

I see. I'm not fully convinced it's due to the disutils deprecation message though. In any case, I'm ok with removing the 3.10 test.

See Python 3.10 documentation https://docs.python.org/3/whatsnew/3.10.html#
vs. https://docs.python.org/3/whatsnew/3.9.html#distutils

The discussion can be found at https://peps.python.org/pep-0632/ (This may result the issue when we have to migrate to Python >=3.10)

We need to keep an eye on this, when in the future Python 3.10 is required.

from requiam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.