Comments (3)
TzuChieh
commented on June 16, 2024
Additional issues found in the process:
- PDF used is for infinite area light. We need to account the radius in Photon as our environment light do have a specific size (
LatLongEnvEmitter::emitRay()andLatLongEnvEmitter::genDirectSample()).
from photon-v2.
TzuChieh
commented on June 16, 2024
I always thought my environment light implementation is slightly off--the noise level just doesn't seem right (just a feeling). Now I think there is actually something wrong: the environment sphere is being modified to have a finite size in an update, and the PDF should not depend on its direction only. Where is the pdfA -> pdfW cosine term? Oh my god....
The default size of the environment sphere is quite large though (> 1km, most cosine terms should be ~1; nevertheless, this is an error).
from photon-v2.
TzuChieh
commented on June 16, 2024
Should be corrected at this point 95805a3.
from photon-v2.
Related Issues (20)
- io_utils should be thread-safe HOT 1
- Currently we use a hack in Photon-v2 and its third-party repo:
- Move `field_set_op` methods into a `CFieldSet` concept
- Properly handle EXR layer name for Blender 3.6 preview
- Consider declare & define macro pairs for SDL definitions
- INI-based internal resource folder setting
- Not maintaining .sh and .bat versions of main setup script
- Update to newer OpenEXR version once signed stride for Imf::Slice is supported HOT 1
- Add C++23 `std::mdspan` support under `TSpan`
- Notes on preserving comments, data packet names, formatting of .p2 files
- Acceleration structure & self-intersection resolution update HOT 2
- Add BDPT
- Add VCM
- PP pipeline should be exposed via SDL
- Add variable poisoning utilities
- Generate common doxygen.config for all projects
- Do not mix the use of `os`, `pathlib` and `shutil`. Try to use `pathlib` where possible.
- Cross referencing child projects from parent project
- Microfacet VNDF sampling
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from photon-v2.