Not fixed bug with leaking string colors about vscode-theme-generator HOT 8 CLOSED

No, I mean targeting the same scopes as all of the embedded vscode themes:

1. "meta.embedded",
2. "source.groovy.embedded"
3. "meta.template.expression"

from vscode-theme-generator.

[] and {} don't actually appear to have assigned colors, adding this looks like it fixes it meta.brace.square, punctuation.definition.block. There are a lot of other brackets at least in the TS grammar that need to be covered

from vscode-theme-generator.

It's a known bug. It affects more that punctuation. I can't find the issue, but the way to fix it is to assign foreground color of each theme

like this:
https://github.com/Microsoft/vscode/blob/master/extensions/theme-monokai-dimmed/themes/dimmed-monokai-color-theme.json#L58

or that:
https://github.com/Microsoft/vscode/blob/master/extensions/theme-monokai-dimmed/themes/dimmed-monokai-color-theme.json#L390

from vscode-theme-generator.

Well foreground is being set:

It's just that the string scope is more specific so it overrides it. I think the only fix is to color all the brackets that could appear within an interpolated string.

from vscode-theme-generator.

Fixed, let me know if you find other similar cases

from vscode-theme-generator.

No, I mean assigning foreground of those scopes that I linked above with the same color as editor.foreground is the official way of fixing this bug.

But if you want to search for every character:

Dot: `text ${func.length} text`
Comma: `text ${[0, 1]} text`
Braces: `text ${() => 0} text`

Probably more...

from vscode-theme-generator.

You mean targeting meta.template.expression.ts meta.embedded.line.ts instead? Probably a better idea...

from vscode-theme-generator.

Thanks for the help @usernamehw 😃

from vscode-theme-generator.