empty popup if <i> is in abbr about abbr-touch HOT 7 CLOSED

Thanks for the report

from abbr-touch.

is there something I can do about that?

from abbr-touch.

Not off the top of my head. To clarify, are you doing this?

<abbr title="A car"><i class="fa fa-car"></i></abbr>

Answering these questions would be helpful:

• Are you passing a customTapHandler into abbrTouch?
• Could you also check if there are any errors in the console?
• Also are using a touch device or touch emulation, not a mouse?

from abbr-touch.

pretty much that example fits it. I use a touch device (galaxy Note 4 with forefox)
I use the normal way with alerts
and the altert itself comes up but with no content, as in alert(""); (or however that would be expressed with js, I am not well versed in that, and that's the reason why I chose the easiest way possible....

from abbr-touch.

Reproduced it here: https://output.jsbin.com/himacagifu

The problem is happening because the touched element on which the tap handler is being called upon is the <i>, not the <abbr>. This might be a bug in https://github.com/Tyriar/touchtap-event

I'll have to do a bit of a deeper dive later on but in the meantime a work around is to use this touch handler:

abbrTouch(document.body, function (target, title, touchX, touchY) {
  var abbr = target;
  while (abbr.tagName !== 'ABBR') {
    abbr = abbr.parentNode;
  }

  // Actual handler
  alert(abbr.title);
});

Demo here:

• https://jsbin.com/hifuwutona/1/edit?html,css,output
• https://output.jsbin.com/hifuwutona/1

Thanks again for reporting!

from abbr-touch.

okay seems to work, mostly, (I put it in my implementation as jsbin has the problem of not working after 90 mins if posted by anonymous, at least that's what they say) and CHromes does as it should, but FIrefox somehow gets 2 alterts.

at least thats over the portforwarding that the chrome dev tools gave me, I will try to get into the network again and try from there.

from abbr-touch.

Fixed and published the fix to npm. The issue was that Event.target was being passed into the tap handler instead of Event.currentTarget.

from abbr-touch.