Comments (9)
AFAIR extendToSubpages
used to not be applied to the hidden field - and I would be surprised if it actually did now; at least I did not see any change like that. It should only apply to the FE user access restrictions. (I just tested it with 6.2 and that behavior is not reproducable).
What TYPO3 version are you on? Can you please make sure this behavior is not caused by another extension you may have installed.
That said, it is a known issue that recursive changes are not being picked up, but that's pretty much a core issue of not propagating a recursive change and not calling hooks for affected sub-pages.
from ext-solr.
I was able to reproduce this now when using the hidden
field. In my previous comment I was thinking about the "Hide in Menu" field. I'm surprised nobody else ran into this yet. The issue about recursive changes remains though.
from ext-solr.
I'll now work on this
from ext-solr.
I've worked on this issue and implemented a functionality in the GarbageCollector and RecordMonitor to apply recursive deletion or reindexing under certain conditions. I've added the above mentioned "triggers".
It would be nice when you can check if this resolved you problem / requirments.
PR can be found here: #192
from ext-solr.
I tested your patch, and while I'm thankful for your effort, we're not quite there yet:
My test pages:
Page A
- Subpage B
When I deactivate page A, page B stays in the index. (This is how it should be)
When I deactivate page A and set the extendToSubpages flag to 1, pages A and B are removed from the index. (This is how it should be)
Page B is now back on the index queue, but on the next indexer run l get an exception:
1319116885: exception 'RuntimeException' with message 'Failed to execute Page Indexer Request. See log for details.
Request ID: 56790aa8edb09' in /var/www/html/t3inn/typo3conf/ext/solr/Classes/IndexQueue/PageIndexerRequest.php:180
Stack trace:
#0 /var/www/html/t3inn/typo3conf/ext/solr/Classes/IndexQueue/PageIndexer.php(167): ApacheSolrForTypo3\Solr\IndexQueue\PageIndexerRequest->send('https://www.der...')
#1 /var/www/html/t3inn/typo3conf/ext/solr/Classes/IndexQueue/PageIndexer.php(62): ApacheSolrForTypo3\Solr\IndexQueue\PageIndexer->getAccessGroupsFromContent(Object(ApacheSolrForTypo3\Solr\IndexQueue\Item), 0)
#2 /var/www/html/t3inn/typo3conf/ext/solr/Classes/Task/IndexQueueWorkerTask.php(128): ApacheSolrForTypo3\Solr\IndexQueue\PageIndexer->index(Object(ApacheSolrForTypo3\Solr\IndexQueue\Item))
#3 /var/www/html/t3inn/typo3conf/ext/solr/Classes/Task/IndexQueueWorkerTask.php(90): ApacheSolrForTypo3\Solr\Task\IndexQueueWorkerTask->indexItem(Object(ApacheSolrForTypo3\Solr\IndexQueue\Item))
#4 /var/www/html/t3inn/typo3conf/ext/solr/Classes/Task/IndexQueueWorkerTask.php(69): ApacheSolrForTypo3\Solr\Task\IndexQueueWorkerTask->indexItems()
#5 /var/www/typo3/typo3-6.2.17/typo3/sysext/scheduler/Classes/Scheduler.php(148): ApacheSolrForTypo3\Solr\Task\IndexQueueWorkerTask->execute()
#6 /var/www/typo3/typo3-6.2.17/typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php(873): TYPO3\CMS\Scheduler\Scheduler->executeTask(Object(ApacheSolrForTypo3\Solr\Task\IndexQueueWorkerTask))
#7 /var/www/typo3/typo3-6.2.17/typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php(191): TYPO3\CMS\Scheduler\Controller\SchedulerModuleController->executeTasks()
#8 /var/www/typo3/typo3-6.2.17/typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php(137): TYPO3\CMS\Scheduler\Controller\SchedulerModuleController->getModuleContent()
#9 /var/www/typo3/typo3-6.2.17/typo3/sysext/scheduler/mod1/index.php(22): TYPO3\CMS\Scheduler\Controller\SchedulerModuleController->main()
#10 /var/www/typo3/typo3-6.2.17/typo3/mod.php(32): require('/var/www/typo3/...')
#11 {main}
This also means that even if i set extendToSubpages back to 0 on page A, page B can't be indexed anymore. I'd have to manually delete page B from the index queue table in the database for that to happen again.
from ext-solr.
@seirerman Thanks for your Feedback. Which TYPO3 Version are you using? Can you maybe check what is in the log? Here the same use case is working. I'll try to reproduce this.
from ext-solr.
We're on 6.2.17.
Devlog says it got a 404 from page B which is correct.
from ext-solr.
@seirerman I've adjusted the patch and checked it on my installation. Can you maybe check again, if everything is fine now?
from ext-solr.
Yes! Looks good to me.
from ext-solr.
Related Issues (20)
- [TASK] Eliminate deprecations in EXT:solr backend modules HOT 2
- [TASK] Fix EXT:solr integration tests
- [TASK] Get rid of ApacheSolrForTypo3\Solr\FrontendEnvironment\Tsfe
- [TASK] Add support for PHPUnit 11
- [TASK] Use updated configSet for solr cores
- [TASK] Update navigationComponent to see page tree
- [TASK] Replace setContent with new moduleTemplate API
- [FEATURE] Dense Vector Search HOT 1
- [FEATURE] Add more information and better handling of indexing errors HOT 1
- Database insertion error due to invalid character (statistics / keywords) HOT 1
- [TASK] Remove config.index_enable usages
- [TASK] Remove MAINTAINER from Dockerfile
- [TASK] Add HEALTHCHECK to Dockerfile
- [BUG] Retrieving plugin name in combination with gridelements leads to warnings within the backend page module HOT 1
- [BUG] numeric facet range slider sends lot of requests to server HOT 1
- [BUG] Suggest component ignores the Plugins `search.query.filter` settings
- [FEATURE] cHash excludedParameters restriction and canonical urls HOT 3
- [BUG] Wrong range string generation in DateRange facet HOT 1
- [FEATURE] Perform case-insensitive sorting
- [BUG] Prevent word truncation with enabled resultsHighlighting HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ext-solr.