Bug: [prefer-readonly-parameter-types] Doesn't work on `DeepReadonly` from `ts-essentials`, `utility-types`, and `type-fest` about typescript-eslint HOT 7 CLOSED

Thank you for pointing this out. I realized that our ts-eslint packages were still 5.59.0, and the allow config was added after 6.0.0. I updated our ts-eslint packages to 7.7.0 and the issue was resolved. Thank you very much for your help!

from typescript-eslint.

Also, how do I check which in StyleDictionary.Core is not covered by DeepReadonly? Thanks.

from typescript-eslint.

Considering this requires a number of different dependencies to reproduce - could you please create an isolated reproduction repo with the required setup to reproduce?

Either that or recreate the exact state in the playground. Note that our playground does not download dependencies so it cannot be run off imports.

from typescript-eslint.

I was able to pinpoint the one data type that might have caused this error, which is RegExp in Parser[], so I decided to use the allow option that you mentioned in this issue to ignore RegExp. However, when I tried to update .eslintrc.js file to include allow config for @typescript-eslint/prefer-readonly-parameter-types, I kept getting the following error:

Oops! Something went wrong! :(

ESLint: 8.54.0

Error: .eslintrc.js#overrides[0]:
	Configuration for rule "@typescript-eslint/prefer-readonly-parameter-types" is invalid:
	Value {"allow":[{"from":"lib","name":"RegExp"}],"ignoreInferredTypes":true} should NOT have additional properties.

    at ConfigValidator.validateRuleOptions (/Volumes/workplace/SamplePackage/src/SamplePackage/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2039:23)
    at /Volumes/workplace/SamplePackage/src/SamplePackage/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2094:18
    at Array.forEach (<anonymous>)
    at ConfigValidator.validateRules (/Volumes/workplace/SamplePackage/src/SamplePackage/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2091:34)
    at ConfigValidator.validateConfigArray (/Volumes/workplace/SamplePackage/src/SamplePackage/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2217:18)
    at CascadingConfigArrayFactory._finalizeConfigArray (/Volumes/workplace/SamplePackage/src/SamplePackage/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3974:23)
    at CascadingConfigArrayFactory.getConfigArrayForFile (/Volumes/workplace/SamplePackage/src/SamplePackage/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3780:21)
    at FileEnumerator._iterateFilesWithFile (/Volumes/workplace/SamplePackage/src/SamplePackage/node_modules/eslint/lib/cli-engine/file-enumerator.js:368:43)
    at FileEnumerator._iterateFiles (/Volumes/workplace/SamplePackage/src/SamplePackage/node_modules/eslint/lib/cli-engine/file-enumerator.js:349:25)
    at FileEnumerator.iterateFiles (/Volumes/workplace/SamplePackage/src/SamplePackage/node_modules/eslint/lib/cli-engine/file-enumerator.js:299:59)

Here's my config for ESLint: Link (Go to eslintrc tab, but the playground cannot reproduce the error I have.)
Can you please help why it doesn't work? Thank you.

from typescript-eslint.

If you can't repro in the playground - then likely your versions don't align.
Given your error message says ESLint: 8.54.0 - that means you're definitely not on ESLint's latest version (8.57.0 for v8 or 9.0.0 for v9) or our latest version (because the latest version explicitly has a dependency on at least ESLint v8.56.0).

So update your deps.

from typescript-eslint.

I just updated the version to 8.57.0, still getting the same error.

from typescript-eslint.

Of eslint, sure, what about our packages?

from typescript-eslint.