Code Monkey home page Code Monkey logo

Comments (5)

kubukoz avatar kubukoz commented on August 14, 2024 3

Nope, still showing warnings if an implicit is used in a macro.

from sbt-tpolecat.

DavidGregory084 avatar DavidGregory084 commented on August 14, 2024

Thanks @kubukoz - we had some discussion about this on #13 where we realised there were problems with all of the macro warning options.

If we use -Ywarn-macros:after, the compiler will warn when there are definitions or imports inside the macro that aren't used, which is outside the caller's control unless they can change the macro code.

If we use -Ywarn-macros:before or -Ywarn-macros:none, the compiler will warn when there are definitions outside the macro that are only used in the macro (i.e. the status quo).

There was some discussion on the PR thread here about adding a -Ywarn-macros:either but it seems like that wasn't taken further as I guess the implementation would be difficult.

Therefore we decided not to change anything at that time just to avoid breakage for users. Do you know if anything has changed in the compiler that would allow us to reevaluate this?

from sbt-tpolecat.

DavidGregory084 avatar DavidGregory084 commented on August 14, 2024

Interestingly it looks like there may be a -Wwarn-macros:both now:

https://github.com/scala/scala/blob/2.13.x/src/compiler/scala/tools/nsc/settings/Warnings.scala#L105

from sbt-tpolecat.

kubukoz avatar kubukoz commented on August 14, 2024

gonna try it out :D

from sbt-tpolecat.

DavidGregory084 avatar DavidGregory084 commented on August 14, 2024

I'm going to close this for now since it doesn't seem like there is any permutation of this option that really works for all users at the moment

from sbt-tpolecat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.