WARNINGs when using 'get()' about ember-typings HOT 3 CLOSED

Hi @peabnuts123, thanks for the detailed writeup!

These are, sadly, well-known issues to me personally, and I'm working on a blog post (probably live tomorrow morning) which walks through the solution (below) for them in some detail. Also note that, thankfully, a lot of this will go away when the ES5 Getters RFC lands (probably Ember 3.1 or 3.2)

In the meantime, the workaround is to explicitly annotate the this type for the methods and especially for computed property functions:

import Controller from '@ember/controller';
import { get, computed } from '@ember/object';

export default class ApplicationController extends Controller {
  value: string;
  
  // `this: ApplicationController` is what you need to make this work as expected.
  init(this: ApplicationController) {
    console.log(get(this, 'value'));
  }
}

Things will generally not work especially well in the old-style .extends() invocations, because there's no named type to give to the this in that case.

Today's workaround in that case (which loses you type safety but makes things type-check) is to do (this as any).get(...) there. Once this DefinitelyTyped PR merges and is live—probably the next day or two—you'll be able to do that with get(this as any, ...) as well. And, since you're on the latest here and with TypeScript, you can also use // @ts-ignore comments where necessary. (It's really unfortunate that all of these escape hatches remain necessary, but they should be getting much better in the next three or four months.)

This will be in the README as well as in a long example blog post sometime in the week. (I'm moving into a new house 🏘️ on Thursday, so everything will be a bit spotty along the way, though.)

from ember-typings.

Oh and FYI my packages@versions are as follows:

├── @types/[email protected]
├── @types/[email protected]
├── @types/[email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

from ember-typings.

Thank for the quick response there Chris! Looking forward to that Getters RFC. The best solution I've found so far is to do something like

  const self = this as ApplicationController

  let value = get(self, value);

in functions, but it's definitely bringing back old jQuery memories. I will try out your this: ApplicationController recommendation. Good to hear things are always on the move, though :)

from ember-typings.