Silent failures with v1.1 about cycle-snabbdom HOT 13 CLOSED

Hopefully it wouldn't, but yes it's possible. I'm just sort of curious, because there are quite a few tests for select() and events(), why none of them would fail if I accidently made a breaking change.

from cycle-snabbdom.

I'll work on adding some more tests to be safe.

from cycle-snabbdom.

I appear to have narrowed down the problem.

There seems to be an issue with the sortNamespace function on isolated elements.

The test I added in this commit fails when using that function, but passes when I comment out the .sort. It fails on the first assertion, so select() can't find anything..

test/browser/isolation.js

from cycle-snabbdom.

Thank you for this. I'll add this test to my work as well. I'll work on a proper fix after work

from cycle-snabbdom.

No problem. Just fulfilling my duties as the guy who has to break every release 😛

from cycle-snabbdom.

Technically I break them, and you help me solve them 👍

from cycle-snabbdom.

I can further confirm that this is strictly related to behavior in isolate()

from cycle-snabbdom.

cc @staltz

This should probably be taken into consideration with https://github.com/cyclejs/cycle-dom/issues/96
I'll PR whatever I figure out over here back to @cycle/dom

from cycle-snabbdom.

@SkaterDad I think I have gathered a proper fix for this. If you don't mind looking at the tests I added before I merge and release the fix, that would be great.

from cycle-snabbdom.

@staltz If you have any input on my solution that would be great too. I'll PR this same thing to cycle-dom soon.

from cycle-snabbdom.

Thanks @TylorS for the tests and the fix. I think so far we have been supporting only classnames. I think it's important we start moving efforts to cycle-dom mainly, because it's being rewritten in Snabbdom (it's basically a merge of this repo with cycle-dom), and naturally this repo would be discontinued.

from cycle-snabbdom.

The tests look pretty good.

it's also great to hear the snabbdom will be used by cycle/dom going forward.

from cycle-snabbdom.

Should be good with v1.1.1. Feel free to reopen if you still encounter issues @SkaterDad

from cycle-snabbdom.