Comments (6)
Plus 1 on this issue. I ran into it a few weeks ago - just before this bug was posted - and I've been tinkering off and on in the hope that it was an implementation error; yesterday I proved it was not. Glad to see I'm not alone. I discovered the issue when I started using Cucumber Studio; it exports features with the quotes included.
@Tyler-Keith-Thompson over the next few days I might have a chance to try to fix this. If you have a solid idea of where the issue is you could point me to it. I'm sure I can track it down but I haven't looked yet at all.
In the meantime I made a run script that strips the quotes. I'd be happy to share if anyone is interested and willing to pardon my hacky bash.
from cucumberswift.
🎉 CucumberSwift v4.2.1 (running in the pipeline as I write this) should solve this problem. There are now 2 lexers, one that tokenizes for stub generation and one that parses Gherkin. The one that parses Gherkin no longer cares about integers or strings (but still cares about doc strings).
from cucumberswift.
Ahh, the lexer did that because it was trying to make it reasonable to generate step stubs with appropriate regular expressions. This was an oversight.
I'll add it to the backlog as a bug.
from cucumberswift.
So the trick here will be to remove the tokenization of string/Int from the lexer.
However, we should add a new lexer that tokenizes steps looking for string/Int for stub generation.
The implementation went the wrong direction when I tried to tokenize for stub generation and Gherkin simultaneously.
However, we now have consumers depending on the current implementation, so we should do another major version rev and either as part of this, or as a fast follow allow # to be escaped.
from cucumberswift.
Based on your description the chances of me tackling this issue feel pretty slim. As much as I'd love to I don't think I have the time to gain the domain understanding to work through it in a reasonable way. I'll be watching for an update and we wil test when it's available.
from cucumberswift.
I'll try and take a look at this in the near future. Things will finally have slowed down a bit for me by this weekend (unless the universe decides to punish me for predicting the future just there).
from cucumberswift.
Related Issues (20)
- Add a screenshot to scenario in AfterScenario HOT 1
- Call another step from current HOT 2
- "Given something #comment" vs "Given the color is #123456" HOT 4
- Stub generation uses deprecated Matcher initializer HOT 1
- Couldn't execute tests/run project - x86_64-apple-macos vs arm64-apple-macos issue HOT 3
- Group steps per scenario in test report HOT 2
- CucumberTest no longer discovered by Xcode HOT 2
- Some tests are not passing because generated code is localised.
- Wrong order of hooks execution. HOT 1
- Usage of symbols < and > in data table produce errors in non Outline Scenarios. HOT 6
- Broken Gherkin language support due to 951bdd3a48900e24d528f0ac65814e2a06dbfdb5 HOT 2
- Empty cell in table error HOT 3
- Steps are reported as passing although the step definition's closure is XCTFail HOT 6
- Scenarios are running 2 times HOT 8
- @ in steps causes error HOT 2
- Couldn't load project from derived data HOT 7
- Compiled module was created by a different version of the compiler
- Error if comment is placed after tag HOT 1
- No GenerateStepStubsIfNecessary in the report navigator HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cucumberswift.