Comments (6)
Not sure why this issue was closed so quickly. I've just committed a fix in a332865.
from cpuid.
hm.. interesting
[sanity.c:246]: (error) Deallocating a deallocated pointer: apic_ids
[sanity.c:247]: (error) Deallocating a deallocated pointer: apic_copy
from cpuid.
Oh. Oops. It was freed already after those for loops... How were these "leaks" detected?
from cpuid.
$ cd cpuid-master
$ cppcheck --enable=performance -v . 2> performance.log
$ cat performance.log
Debug mode:
[sanity.c:246]: (error) Deallocating a deallocated pointer: apic_ids
[sanity.c:247]: (error) Deallocating a deallocated pointer: apic_copy
[sanity.c:126]: (debug) inconclusive leak of apic_state: ; assign ; alloc ; loop use ; dealloc ; return ; }
[sanity.c:128]: (debug) inconclusive leak of busy_workers: ; assign ; alloc ; loop use ; dealloc ; return ; }
[sanity.c:129]: (debug) inconclusive leak of apic_workers: ; assign ; alloc ; loop use ; dealloc ; return ; }
from cpuid.
I looked more closely at the codepath. The 'goto cleanup' skips over the deallocations if there's duplicate APIC IDs. I've fixed it up.
from cpuid.
@tycho, Thanks FixIt.
from cpuid.
Related Issues (11)
- a question HOT 6
- Please add TSC non-stop HOT 7
- Build error at link time HOT 3
- Add 0x80000008 (specifically EBX for AMD)
- Reading the microcode revision number would be nice HOT 2
- Add cpuid man page HOT 4
- Not dumping leaf 0x10 HOT 1
- Doesn't compile in Visual Studio 2013 HOT 5
- Cross Compilation for Arm64 HOT 1
- A project name collision HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cpuid.