Chezmoi Fails to Detect Git about chezmoi HOT 6 CLOSED

If chezmoi does a lookPath before step 4, does that affect the resolution?

No. The lookup error is cached in the os/exec.Cmd struct and is unaffected by other calls to os/exec.LookPath. See https://github.com/golang/go/blob/go1.20.6/src/os/exec/exec.go#L418-L429.

from chezmoi.

We need to understand what you are seeing more explicitly before we can declare it as a bug or correct behaviour, therefore it is a support request.

from chezmoi.

OK, this one is interesting. It's a "feature" of Go standard library's os/exec.Command function. What's happening it:

1. When chezmoi reads the external file, it creates the os/exec.Cmd structure for the git command to be run using os/exec.Command.
2. os/exec.Command immediately looks for the git command, which it doesn't find, as git is not yet installed. It then stores that not found error for later.
3. Later, chezmoi runs the install-git.sh script, which installs git.
4. Later, chezmoi calls Run() on the os/exec.Cmd it created in step 1. Instead of checking again for the presence of git in $PATH, Go's standard library returns the not found error it saved at step 2.

I'll have a think about how to fix this.

from chezmoi.

I'm a bit puzzled as to why this was flagged as "support"? I followed the manpage exactly, and the only deviation is that the prerequisite seems to be necessary for external sources rather than template expansion.

• /usr/bin is in PATH
• Git is installed within the run_before_ script to /user/bin/git
• The external sources are cloned after the run_before_ scripts

Considering these factors, it seems logical that chezmoi should be able to locate git without any issues. It manages to do so when I run chezmoi apply a second time. So, I'm left wondering why it doesn't work on the initial run.

To me, this situation appears to be a bug because the ideal scenario would be to install everything, including prerequisites and dotfiles, with a single command (like sh -c "$(curl -fsLS get.chezmoi.io/lb)" -- init --apply <username>)

from chezmoi.

If chezmoi does a lookPath before step 4, does that affect the resolution?

from chezmoi.

Thanks for the fast bugfix. You guys are amazing ! ❤️

from chezmoi.