Code Monkey home page Code Monkey logo

Comments (1)

twpayne avatar twpayne commented on September 21, 2024 1

I did some further investigation, and I don't think memfd_create is worth using because:

  1. For commands that invoke an external process, like chezmoi diff, chezmoi edit, and chezmoi merge, the filename on disk is important (c.f. #1481), so using an in-memory file descriptor is not sufficient as it has no meaningful filename.
  2. Where possible, chezmoi already uses pipes to communicate with subprocesses. These already have the advantage of anonymity and being automatically cleaned up when chezmoi exits.
  3. memfd_create is not available on all OSes (e.g. macOS and Windows), so the existing temporary file code needs to be maintained for these OSes anyway.

Overall, there might be a couple of cases where chezmoi is using temporary files where memfd_create would make more sense. If you would like to contribute such an improvement then searching the source code for TempDir and os.MkdirTemp is a good start for finding where temporary files and directories are currently used. For now, I'll close this issue.

from chezmoi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.