Comments (9)
Hi @twopirllc,
thanks for such a lighting fast response. :)
Yes, you are correct in assuming that I am not using talib. I think the issue boils down to the fact the development branch is using rma
as the default ma instead of sma
which is on the main branch.
If I set the mamode="sma" parameter like so
import pandas_ta as pta
df[DataframeColumns.RSI] = pta.rsi(
df[DataframeColumns.CLOSE], length=self.settings.rsi_default_length, mamode="sma"
)
the prenans are returned as expected.
from pandas-ta.
Oh yeah! It has been awhile since I touch rsi. Seems I chose to default to TradingView's rma calculation if TA Lib is not installed.
from pandas-ta.
Yes it is easy to forget changing settings over time.
Anyways, your help and input is very much appreciated and thanks for this brilliant library, it has proven most useful for our project.
Sponsorship or donations help massively to keep this project alive. 😎
Thanks!
from pandas-ta.
apologies for lateness here, been up to my eyeballs with life/work/kids/etc. the coffee has been delivered. ☕
from pandas-ta.
I know how it is. Much appreciated. Thank you!
from pandas-ta.
Hello @einarjohnson,
RSI works as intended with the prenans. There are no plans to alter this behavior.
Unfortunately, I am unable to replicate you results with the development branch. What is your code to reproduce the resultant output?
Kind Regards,
KJ
from pandas-ta.
Oh I see... you are not using TA Lib. Looks like you are correct with the lack of prenans for the Pandas TA RSI version.
You are correct that it should have prenans there. I'll add it to the todo list. Thanks for the heads up.
from pandas-ta.
Interesting. SMA seems to be the default one when I use TW and RMA(labelled as SMMA?) appears to be unselected.
maybe this is a user setting or something that is bound to my account, could very well be since I use TW so much and I might have changed this at some stage (i can't remember doing that though)
Anyways, your help and input is very much appreciated and thanks for this brilliant library, it has proven most useful for our project.
from pandas-ta.
🤣
from pandas-ta.
Related Issues (20)
- Having trouble attempting to "import pandas_ta as ta" HOT 2
- NATR in non TA-lib mode HOT 1
- How To Test TMO Indicator HOT 8
- Adjusted Close vs Close HOT 4
- Pythonv3.12 support HOT 2
- Indicators using moving averages variable does not pass kwargs to ma(mamode, close, length=length) HOT 1
- Attribute error when I remove a specific group from dataframe HOT 2
- Fix for RMA - adjust=False
- natr behaves the same as atr(percent=True)
- ta.cci returns entire original dataframe if there aren't enough rows for the period value HOT 1
- outstanding tickets for next release? HOT 3
- Failing tests HOT 3
- EVERYONE: Removing the 'fillna' keyword option if there is no opposition!
- can you support smc/bos/choch smart money indicator HOT 2
- The Jurik Moving Average (JMA) is a proprietary indicator, How likely is it to be close to the actual implementation as it looks quite like a closely guarded secret? HOT 4
- Discripency Between Yahoo Finance and Panda's TA in Accumulation/Distribution Indicator HOT 1
- StochRSI on development branch HOT 3
- ta.Category list value gets truncated HOT 1
- Statistics module does not export pstdev. Installation error in colab HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pandas-ta.