Code Monkey home page Code Monkey logo

Comments (9)

einarjohnson avatar einarjohnson commented on May 23, 2024 1

Hi @twopirllc,
thanks for such a lighting fast response. :)

Yes, you are correct in assuming that I am not using talib. I think the issue boils down to the fact the development branch is using rma as the default ma instead of sma which is on the main branch.

If I set the mamode="sma" parameter like so

import pandas_ta as pta

df[DataframeColumns.RSI] = pta.rsi(
    df[DataframeColumns.CLOSE], length=self.settings.rsi_default_length, mamode="sma"
)

the prenans are returned as expected.

from pandas-ta.

twopirllc avatar twopirllc commented on May 23, 2024 1

@einarjohnson

Oh yeah! It has been awhile since I touch rsi. Seems I chose to default to TradingView's rma calculation if TA Lib is not installed.

from pandas-ta.

twopirllc avatar twopirllc commented on May 23, 2024 1

@einarjohnson

Yes it is easy to forget changing settings over time.

Anyways, your help and input is very much appreciated and thanks for this brilliant library, it has proven most useful for our project.

Sponsorship or donations help massively to keep this project alive. 😎

Buy me a Coffee

Thanks!

from pandas-ta.

einarjohnson avatar einarjohnson commented on May 23, 2024 1

apologies for lateness here, been up to my eyeballs with life/work/kids/etc. the coffee has been delivered. ☕

from pandas-ta.

twopirllc avatar twopirllc commented on May 23, 2024 1

I know how it is. Much appreciated. Thank you!

from pandas-ta.

twopirllc avatar twopirllc commented on May 23, 2024

Hello @einarjohnson,

RSI works as intended with the prenans. There are no plans to alter this behavior.

Screenshot 2024-03-09 at 11 11 46 AM

Unfortunately, I am unable to replicate you results with the development branch. What is your code to reproduce the resultant output?

Kind Regards,
KJ

from pandas-ta.

twopirllc avatar twopirllc commented on May 23, 2024

@einarjohnson

Oh I see... you are not using TA Lib. Looks like you are correct with the lack of prenans for the Pandas TA RSI version.

Screenshot 2024-03-09 at 11 25 38 AM

You are correct that it should have prenans there. I'll add it to the todo list. Thanks for the heads up.

from pandas-ta.

einarjohnson avatar einarjohnson commented on May 23, 2024

Interesting. SMA seems to be the default one when I use TW and RMA(labelled as SMMA?) appears to be unselected.
image

image

maybe this is a user setting or something that is bound to my account, could very well be since I use TW so much and I might have changed this at some stage (i can't remember doing that though)

Anyways, your help and input is very much appreciated and thanks for this brilliant library, it has proven most useful for our project.

from pandas-ta.

twopirllc avatar twopirllc commented on May 23, 2024

🤣

from pandas-ta.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.