Unnamed TAG_Compound raises exception when it it serialized about nbt HOT 4 OPEN

I don't have time to look into it, but I suspect it has to do with this line:

Villages = TAG_List(type=TAG_Compound)

I would replace it with:

Villages = TAG_List(name = "Villages", type=TAG_Compound)

Let me know if this works,

from nbt.

When an unnamed TAG_Compound object is serialized with _render_buffer(), it raises the following exception:

Traceback (most recent call last):
  method <module> in test.py at line 69
    villages.write_file("villages.dat")
  method write_file in test.py at line 575
    self._render_buffer(self.file)
  method _render_buffer in test.py at line 401
    tag._render_buffer(buffer)
  method _render_buffer in test.py at line 400
    TAG_String(tag.name)._render_buffer(buffer)
  method _render_buffer in test.py at line 268
    save_val = self.value.encode("utf-8")
AttributeError: 'NoneType' object has no attribute 'encode'

A quick fix is to assume name is "" when it is not set (or simply set it to "" instead of None as the default).

Braindump: I don't think this leads to unexpected problems, but it does point to what I nowadays consider a design flaw in the NBT library: there is no clear distinction between a TAG and a Named TAG object. This distinction is only made by the calling function, not by the object itself. E.g., there is no clear distinction between a Named TAG with the name set to "", or a (unnamed) TAG with the name attribute set to None.

from nbt.

Well, you are right. I totally forgot to name that list, because I thought it has no name in the "villages.dat" minecraft file.

Also it turns out that I don't need, this lines:

Players = TAG_List(type=TAG_End, name="Players")
compound.tags.append(Players)

Since the file that the program wrote works fine, minecraft is actually doing this line for me.
At first i was scared that the order of the tags matters but it doesn't.

Thanks.

from nbt.

@Omeganx good to hear, you got it fixed. Thanks for reporting it.

I'll keep this open for a while; even when you don't name a TAG_Compound, it should not raise this error. If it is allowed in a NBT file, it should just serialize it. If it is not allowed in a NBT, it should raise a decent exception.

from nbt.