Code Monkey home page Code Monkey logo

Comments (8)

twolfson avatar twolfson commented on July 20, 2024 1

The issue is you're missing the useIframe: false. We need this to properly use require across multiple levels of node modules. Closing issue eagerly

from karma-electron.

twolfson avatar twolfson commented on July 20, 2024

I can't seem to find the karma-electron integration on any branch. Can you link me to it?

from karma-electron.

j-a-m-l avatar j-a-m-l commented on July 20, 2024

Sorry @twolfson , I didn't push any commit with my attempts.

But now, since you asked about it, I've pushed a branch to my forked repo with some temporal changes:
https://github.com/j-a-m-l/ark-desktop/tree/debug-karma-electron

from karma-electron.

j-a-m-l avatar j-a-m-l commented on July 20, 2024

Thanks @twolfson.

That wasn't right, but now the errors is: "Cannot read 'concat' of undefined". Replacing

module.paths = module.paths.concat(__require('module')._nodeModulePaths('{{!karmaBasePath}}'));

with

module.paths = (module.paths || []).concat(__require('module')._nodeModulePaths('{{!karmaBasePath}}'));

would fix it.

But it would trigger other problem: "Maximum call stack size exceeded".

from karma-electron.

twolfson avatar twolfson commented on July 20, 2024

I looked into this a bit and that error is being caused by angular-mocks.js overwriting Node.js' definition of module which is leading to a sticky situation

After disabling angular-mocks, I'm seeing the "Maximum call stack size exceeded" between our window.require definition and Mocha's wrapper. I'm looking into why this doesn't happen in our other frameworks

from karma-electron.

twolfson avatar twolfson commented on July 20, 2024

Also, fwiw, I disabled coverage so the stack traces are more legible -- especially via the "Debug" window (requires disabling --single-run and opening via "Debug" button)

from karma-electron.

twolfson avatar twolfson commented on July 20, 2024

It looks like the issue is being caused by 4.0.0 version of mocha (released about 1 month ago) which overwrites the global require. Downgrading to 3.5.3 fixed the issue and moved to a new one for Angular in the repo's domain:

Electron 1.8.1 (Node 8.2.1) ERROR
  Uncaught TypeError: module is not a function
  at services/network.service.js:23

which corresponds to:

describe('networkService', function () {
  beforeEach(module('arkclient.services'))

It looks like there's already a Mocha require= related issue so I'd suggest subscribing to that and using a downgraded version for now:

mochajs/mocha#3091

from karma-electron.

j-a-m-l avatar j-a-m-l commented on July 20, 2024

Thank you very much for all your help.

from karma-electron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.