Comments (3)
H Niklas!
Thx for contacting me! I was very busy with work so I haven't yet tested your code, but I had a look at the egerrit.el code serveral times. There is now a WIP wiki page that compares our packages in https://github.com/thisch/gerrit.el/wiki/Comparison-of-gerrit.el-with-egerrit.el Feel free to extend this page.
I haven't made any new changes to gerrit.el lately, but I plan to change this soon, but first I'll finally test your pkg ;) Give me two weeks for that. I'll contact you no later than June 25th - I need deadlines ;)
BTW Do you have a roadmap for your project or what are the features that you want to implement next?
from gerrit.el.
No stress, great initiative with the comparison wiki. I'll see if I have something to add :). I like the idea of using plz instead of having to re-invent the wheel for the requests. Unfortunately I seem to run into this bug alphapapa/plz.el#3. I think it should be easy to transition to using plz once that has been sorted out :)
Haha, alright ;) No pressure from my side :)
That's a good question. This is what I have had in mind recently:
- Using the rest api to get the patch diff for the review as well as partial review. The partial review diff now can show which hunks are due to a rebase, which is something I have missed from the web ui.
- Re-introduce transient for commands. I removed it because I thought it was unnecessary to have magit as a dependency for just transient, but now since its part of ELPA I think it make sense to go back to using it.
- Improve the comments buffer for reviews. Current implementation could be improved when it comes to finding out the relation between a comment and the location in the diff buffer. Also I would like the user to be able to hide/show comments that are closed. Currently only open comments are shown, which is most of the time what one wants but its beneficial to have control of it from a users perspective.
- Support for a dedicated review repo. I would like the users to optionally be able to have a repository for only reviews, which should be different from the code repository. This is useful for those times that one might be running some evaluation in the code repository and while waiting want to do some reviews. But then its not possible to go into review-mode where the source code is checked out locally.
That's what I am thinking would be up next for the moment :)
from gerrit.el.
I have created a branch named restructure, where I have initiated work to split up the code in several files to make it easier to grasp :) https://git.sr.ht/~niklaseklund/egerrit/tree/restructure
from gerrit.el.
Related Issues (20)
- Replace usage of `git-review` cli tool by gerrit REST api HOT 1
- Support autostashing in `gerrit-download`
- Automatically install commit-msg hook
- Function that downloads a review (independent of CWD) and opens an (editable) overview of the change HOT 1
- Support for reviewing gerrit changes HOT 1
- Drop support for legacy git-review interface
- Factor out dashboard code into a new pkg HOT 1
- Output "no-new-changes" message in echo-area
- Don't override locally modified by a checkout of a gerrit change
- gerrit-upload dryrun: output diff for already uploaded changes
- Add support for gerrit 3.4+ HOT 1
- dashboard buttons only work if they have not been opened previously HOT 2
- only the first page of gerrit account results get fetched HOT 9
- feature request: allow new arguments to be added to upload transient HOT 3
- error display with Chinese words HOT 2
- Perform additional checks at the beginning of gerrit-upload
- Add interactive function for downloading specific patchset of a single change
- Add dashboard
- Number of gerrit accounts limit (=500) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gerrit.el.