Code Monkey home page Code Monkey logo

Comments (2)

hawkowl avatar hawkowl commented on May 29, 2024

The circular dependency is only for running tests, so I don't think this should present an issue for packaging?

from incremental.

freeekanayaka avatar freeekanayaka commented on May 29, 2024

Well, python Debian packages these days run unit tests by default at build time. So this means there's a circular dependency at Build-Depends level (iow to build the incremental Debian package you need the twisted Debian package and the other way round).

From a quick look it seems that the tests import just generic twisted utilities like twisted.python.filepath or use twisted.trial.unittest.TestCase.mktemp, both of which are arguably non specific to Twisted and could be extracted, exactly like incremental itself was extracted. Or simply incremental could just use stdlib constructs directly at the price of some micro duplication, or vendor the relevant code from Twisted (would be very small, I believe).

Really, there's no real conceptual dependency between the tests of the incremental package and twisted-the-async-framework. It's just incidental convenience, because twisted-the-actual-package happens to ship a few universally handy bits, and this bits are so small that pulling in the entire twisted to get them seems odd to me.

from incremental.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.