Comments (4)
Hi @treyrich, thanks for the report. We did recently refactor the internals to be more strictly follow state transitions. I think there are two things we could do here
- Be more lenient in Conversation's
disconnect
method—i.e. is it really useful to throw ifdisconnect
is called twice? - Expose the Conversation state, either an
isConnected
or some other state property.
from twilio-video.js.
Right. I think either would work. I mean honestly I was able to refactor my code to cover most cases pretty well. But it's just nice if in your teardown code you're able to just call conversation.disconnect()
without having to worry about it potentially throwing an error if it was previously disconnected. It can certainly be handled by the developer, but it seems like since the library is already storing the state that it's redundant for the developer to do so also.
Personally I think that it will promote better, more well thought out, code to go with option 2 and expose the conversation state in some way, and continue the strict checking.
from twilio-video.js.
That is good feedback, @treyrich—thank you. I will share it with the team.
from twilio-video.js.
Hi @treyrich,
We've recently made a number of changes to the Video SDK: it's now called twilio-video.js instead of twilio-conversations.js; we've also simplified the object model (no more invites, Conversations are replaced by "Rooms", etc.).
The full API docs can be found here, but importantly we've
- Added a
state
property to the Room (which is either "connected" or "disconnected"), and - Multiple
disconnect
s no longer throw.
Hopefully this improves over the Conversations behavior.
Best,
Mark
from twilio-video.js.
Related Issues (20)
- Intermittent video stream flickering on Android/Chrome
- participant.networkQualityLevel Returns Null When Connect to a Room with Audio and Video Off HOT 1
- Failed to execute 'send' on 'WebSocket': Still in CONNECTING state.
- DOMException error with no stack trace
- Restarting local audio track with noise cancellation
- Angular 6 Uncaught TypeError: Cannot assign to read only property 'exports' of object '[object Object]' ;
- Apple hand gestures getting sent on video call HOT 1
- End of Life HOT 2
- Twilio Programmable Video End of Life and Transition Plan HOT 10
- Thank You
- Issue with datatracks React - Sometimes participants new are not subcribed
- Video: Test Group Room with TURN & Video: Test Group Room without TURN FAILS HOT 1
- Mark Brave supported HOT 1
- Anyone experiencing crashes with Chrome v122? HOT 11
- Officially support Chromium's new documentPictureInPicture API HOT 1
- Allow calling `track.restart()` on local tracks created using constructors HOT 1
- Black video stream issue
- FitType Property is not applying on webgl but working on canvas2D
- Build is broken
- Screen Turns White switching between front and rear cameras for iPhone 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twilio-video.js.