Comments (8)
I've enabled a vertical layout in 0.0.7 and plan to add buttons to toggle the terminal and coverage panels. I think this may be a better solution to multiple tabs.
from atom-phpunit-integrator.
I've got most (all) of the event system in place for #9 I just want to get this main component functioning correctly before I go adding further dependencies.
I left the coverage view in place since it also adds the ability to sort the files based on percentage and statements (un)covered, which I often use myself. While the tree view would be useful, in large projects it could be combersome to expand several folders just to find that one file with 98% coverage ;)
from atom-phpunit-integrator.
You mentioned in #3 that the icons are not displaying. There should be a button there to filter the results in the tree. The assertation messages should also be expandable on the individual tree items.
The three individual panes can be resized by dragging the divider, the package will also remember the positions during reload. But, the ability to hide each pane would be useful.
from atom-phpunit-integrator.
@Gert-dev Thanks for the taking the time to test the package and especially for the feedback 👍
from atom-phpunit-integrator.
Thanks for taking the time to respond and you're very welcome.
I got #3 to work with another project and saw the failed assertions, which is exactly what I was looking for. Feel free to close this or keep it open for the pane. I could also create a separate ticket about it, if you want (or the issue title could be updated).
On the subject of hiding the raw output pane, I was just moving around the dock and noticed that, because all three panes are integrated into one single dock, it isn't very flexible in its location. For example, if you wanted it as a sidebar, it is very cramped in space.
A more interesting approach than allowing to hide the console might be to just split the three panes up into separate tabs (docks). That way the user can position them independently and just close any one of them he doesn't want - there should still be some way to reopen them, if closed, however. Positioning them next to each other is also still possible, this way.
from atom-phpunit-integrator.
I too noticed that moving the view to the sidebar is just ugly. I'm so used to my own environment layout that I never though about having the tree view in the sidebar. Individual tabs sounds like a good idea, I'm just not sure how to manage opening them. Keyboard shortcuts would work, but I feel atom is already overflowing with shortcuts, it's becoming difficult to avoid conflicts. I'll give this some thought.
from atom-phpunit-integrator.
v0.0.11 has improved vertical layout support. Also added the ability to toggle the terminal and coverage views on/off.
@Gert-dev Let me know if you think separate tabs would still be required.
from atom-phpunit-integrator.
Thanks. After you fixed the ability to have a vertical pane, the need for separate docks quickly went away. Now that there is a loading spinner and the failures are visible inline, the need for the output console has also reduced (so I've hid it by default). Finally, I like that the coverage view can be toggled when needed, but think that it ultimately could also be replaced by #9, if it were to be implemented.
from atom-phpunit-integrator.
Related Issues (20)
- TypeError: Cannot read property 'setAttribute' of undefined HOT 3
- TypeError: Cannot read property 'target' of undefined HOT 2
- Error: Failed to resolve extends for '\PHPUnit\Framework\TestCase' in (DateTime,DateTimeImmutable, ...) HOT 5
- Debug and code coverage toggle seems to have disappeared HOT 3
- Cannot read property 'startsWith' of undefined HOT 2
- Docker support HOT 6
- New testMethod written outside of class HOT 2
- docblocks missing
- Select methods to generate
- Menu items are visible for projects missing a phpunit.xml
- Subdirectories
- resolved.scope.getRange is not a function
- Failed loading Zend extension 'undefined'
- Uncaught TypeError: Cannot read property 'getSelectedSuiteNames' of null
- Uncaught Error: An element for 'Container6umlajn' could not be found in [...] HOT 2
- Links broken
- Cannot read property 'getFileReports' of null HOT 1
- Re-Run last test
- Cannot run tests for current method, current class or current file HOT 1
- Ability to generate code coverage seems to have disappeared HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from atom-phpunit-integrator.