Comments (5)
This seems unintuitive indeed, so will mark as a bug. Do you have a sample? Here's a starting point: https://codepen.io/trusktr/pen/OJRQjZw
from tween.js.
Not sure if this small code was required, but here is the demonstration that the tween from a Group's array gets removed after pausing a tween:
const DATA = { 'X': 0 };
const TWEEN_DATA = { 'X': 1000 };
const TWEEN_GROUP = new TWEEN.Group();
new TWEEN.Tween(DATA, TWEEN_GROUP).to(TWEEN_DATA).duration(1000).onUpdate(UpdateCallback).start();
function UpdateCallback() {
console.log(DATA);
}
function Animate() {
requestAnimationFrame(Animate);
TWEEN_GROUP.update();
}
Animate();
setTimeout(function () {
console.log('Array Length Before Pausing: ' + TWEEN_GROUP.getAll().length);
TWEEN_GROUP.getAll()[0].pause();
console.log('Array Length After Pausing: ' + TWEEN_GROUP.getAll().length);
}, 500);
from tween.js.
Yeah, totally I see that. I meant, do you have an example of a problem this is causing?
Even long ago before TWEEN was made into a Group, and before there was pause(), Tweens were added or removed on start/stop:
Line 10 in cbc0df9
So we need to see an example of the problem.
from tween.js.
I found a code related to this issue.
Lines 284 to 285 in e01bbdb
Lines 301 to 302 in e01bbdb
All tween instances hold a reference to a group. On pause, tween removes itself from a group and re-adds itself on resume.
Lines 393 to 394 in e01bbdb
Tween.update() skips paused tween. Because of this, it is not necessary to remove and re-add tweens to a group.
The downside of this behavior is that it can be confusing when users use Group to manage and manipulate their tween.
The advantage of this behavior is that the update loop is faster if the mainGroup holds a large number of paused tween.
from tween.js.
Ah indeed, should be easy to implement!
from tween.js.
Related Issues (20)
- Make sure GitHub Pages is synced so that docs stay up to date. HOT 1
- `Timeline` feature HOT 1
- CJS entry point can't be loaded in Node.js HOT 4
- How to update .to value onRepeat? HOT 1
- Tween can't be restarted from onComplete callback. HOT 1
- [vite] Internal server error: Failed to resolve import "@tweenjs/tween.js/dist" from "src\index.ts". Does the file exist? HOT 3
- Simplify Tween, remove some stuff, make it easier to maintain. HOT 9
- Repeating value is incorrect over time HOT 1
- Proposal : Fix runs-on label - Directly specify Ubuntu 22.04 HOT 3
- [bug] calling tween.stop() does not cause tween.update() to return false
- CJS import broken HOT 2
- when time is negative, the result is bad HOT 4
- chain doesn't work HOT 3
- link to understanding-tweenjs not working :( HOT 1
- Types are not included with ModuleResolution `Node16` or `Bundler` options HOT 1
- [bug] yoyo has wrong value HOT 4
- Will the value not be automatically updated? HOT 1
- I want to rotate in the positive direction, but can't I click a button to rotate in the opposite direction? HOT 5
- ThreeJS Object3D flickers when tweening with yoyo turned on. HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tween.js.